linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Joachim Fenkes <fenkes@de.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>,
	OF-EWG <ewg@lists.openfabrics.org>,
	linuxppc-dev@ozlabs.org, Christoph Raisch <raisch@de.ibm.com>,
	Marcus Eder <meder@de.ibm.com>,
	OF-General <general@lists.openfabrics.org>,
	Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5
Date: Mon, 10 Dec 2007 13:47:37 -0800	[thread overview]
Message-ID: <adahciq9q86.fsf@cisco.com> (raw)
In-Reply-To: <200712101841.30010.fenkes@de.ibm.com> (Joachim Fenkes's message of "Mon, 10 Dec 2007 18:41:29 +0100")

 > >     map_phys_fmr
 > 
 > In fact, we do use hCalls there. Our hardware doesn't actually support FMRs,
 > so we translate a "map FMR" into a "reallocate PMR", which doesn't work
 > without hCalls. What's more, the hCalls involved (e.g. H_FREE_RESOURCE)
 > might well return H_LONG_BUSY, so the whole operation might sleep; no way
 > around it.

It's a big problem.  If you cannot implement FMRs in such a way that
you can handling having map_phys_fmr being called in a context that
can't sleep, then I think the only option is to remove your FMR
support.  It's an optional device feature, so this should be OK
(although the iSER driver currently seems to depend on a device
supporting FMRs, which is probably going to be a problem with iWARP
support in the future anyway).

The fact that consumers can map FMRs from interrupt context, while
holding locks, etc, is pretty fundamental to the use of FMRs so I
don't see any way around the requirement that map_phys_fmr never
sleep.

 - R.

  reply	other threads:[~2007-12-10 21:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06 15:07 [PATCH] IB/ehca: Serialize HCA-related hCalls on POWER5 Joachim Fenkes
2007-12-06 15:48 ` Arnd Bergmann
2007-12-06 18:27   ` Roland Dreier
2007-12-07  9:58     ` Arnd Bergmann
2007-12-09 23:22       ` Roland Dreier
2007-12-10 17:41         ` Joachim Fenkes
2007-12-10 21:47           ` Roland Dreier [this message]
2007-12-11  8:38             ` Joachim Fenkes
2007-12-12 12:14               ` [ewg] " Or Gerlitz
2007-12-12 16:02                 ` Christoph Raisch
2007-12-12 19:09                 ` Roland Dreier
2007-12-13  8:30                   ` Or Gerlitz
2007-12-13 19:22                     ` [ofa-general] " Caitlin Bestler
2007-12-13 20:59                       ` Joachim Fenkes
2007-12-13 21:08                         ` Caitlin Bestler
2007-12-13 21:35                           ` Joachim Fenkes
2007-12-13 21:48                           ` [ofa-general] Re: [ewg] Re: [PATCH] IB/ehca: SerializeHCA-related " Sean Hefty
2007-12-07 16:25     ` [PATCH] IB/ehca: Serialize HCA-related " Joachim Fenkes
     [not found] <OF85E31FAA.DADA6039-ONC12573AA.005439C8-C12573AA.005A132E@LocalDomain>
2007-12-10 17:59 ` Joachim Fenkes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adahciq9q86.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=arnd@arndb.de \
    --cc=ewg@lists.openfabrics.org \
    --cc=fenkes@de.ibm.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=meder@de.ibm.com \
    --cc=raisch@de.ibm.com \
    --cc=stefan.roscher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).