[PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

[PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

[Hoang-Nam Nguyen]

=46rom b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001
=46rom: Hoang-Nam Nguyen <hnguyen at de.ibm.com>
Date: Fri, 27 Jul 2007 10:24:49 +0200
Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided=
 in .c files"

Signed-off-by: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
=2D--
 drivers/infiniband/hw/ehca/ehca_classes.h |    1 +
 drivers/infiniband/hw/ehca/ehca_mrmw.c    |    2 --
 drivers/infiniband/hw/ehca/ehca_pd.c      |    1 -
 drivers/infiniband/hw/ehca/hcp_if.c       |    1 -
 drivers/infiniband/hw/ehca/ipz_pt_fn.h    |    2 ++
 5 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h b/drivers/infiniband=
/hw/ehca/ehca_classes.h
index 3725aa8..b5e9603 100644
=2D-- a/drivers/infiniband/hw/ehca/ehca_classes.h
+++ b/drivers/infiniband/hw/ehca/ehca_classes.h
@@ -322,6 +322,7 @@ extern int ehca_static_rate;
 extern int ehca_port_act_time;
 extern int ehca_use_hp_mr;
 extern int ehca_scaling_code;
+extern int ehca_mr_largepage;
=20
 struct ipzu_queue_resp {
 	u32 qe_size;      /* queue entry size */
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c b/drivers/infiniband/hw=
/ehca/ehca_mrmw.c
index c1b868b..773ac3f 100644
=2D-- a/drivers/infiniband/hw/ehca/ehca_mrmw.c
+++ b/drivers/infiniband/hw/ehca/ehca_mrmw.c
@@ -64,8 +64,6 @@ enum ehca_mr_pgsize {
 	EHCA_MR_PGSIZE16M =3D 0x1000000L
 };
=20
=2Dextern int ehca_mr_largepage;
=2D
 static u32 ehca_encode_hwpage_size(u32 pgsize)
 {
 	u32 idx =3D 0;
diff --git a/drivers/infiniband/hw/ehca/ehca_pd.c b/drivers/infiniband/hw/e=
hca/ehca_pd.c
index 3dafd7f..43bcf08 100644
=2D-- a/drivers/infiniband/hw/ehca/ehca_pd.c
+++ b/drivers/infiniband/hw/ehca/ehca_pd.c
@@ -88,7 +88,6 @@ int ehca_dealloc_pd(struct ib_pd *pd)
 	u32 cur_pid =3D current->tgid;
 	struct ehca_pd *my_pd =3D container_of(pd, struct ehca_pd, ib_pd);
 	int i, leftovers =3D 0;
=2D	extern struct kmem_cache *small_qp_cache;
 	struct ipz_small_queue_page *page, *tmp;
=20
 	if (my_pd->ib_pd.uobject && my_pd->ib_pd.uobject->context &&
diff --git a/drivers/infiniband/hw/ehca/hcp_if.c b/drivers/infiniband/hw/eh=
ca/hcp_if.c
index fdbfebe..24f4541 100644
=2D-- a/drivers/infiniband/hw/ehca/hcp_if.c
+++ b/drivers/infiniband/hw/ehca/hcp_if.c
@@ -758,7 +758,6 @@ u64 hipz_h_register_rpage_mr(const struct ipz_adapter_h=
andle adapter_handle,
 			     const u64 logical_address_of_page,
 			     const u64 count)
 {
=2D	extern int ehca_debug_level;
 	u64 ret;
=20
 	if (unlikely(ehca_debug_level >=3D 2)) {
diff --git a/drivers/infiniband/hw/ehca/ipz_pt_fn.h b/drivers/infiniband/hw=
/ehca/ipz_pt_fn.h
index c6937a0..a801274 100644
=2D-- a/drivers/infiniband/hw/ehca/ipz_pt_fn.h
+++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.h
@@ -54,6 +54,8 @@
 struct ehca_pd;
 struct ipz_small_queue_page;
=20
+extern struct kmem_cache *small_qp_cache;
+
 /* struct generic ehca page */
 struct ipz_page {
 	u8 entries[EHCA_PAGESIZE];
=2D-=20
1.5.2

Re: [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

[Sam Ravnborg]

On Fri, Jul 27, 2007 at 12:54:50PM +0200, Hoang-Nam Nguyen wrote:
> >From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001
> From: Hoang-Nam Nguyen <hnguyen at de.ibm.com>
> Date: Fri, 27 Jul 2007 10:24:49 +0200
> Subject: [PATCH] remove checkpatch.pl's warnings "externs should be avoided in .c files"
> 
> Signed-off-by: Hoang-Nam Nguyen <hnguyen@de.ibm.com>

And you checked that said .h file was indeed included by the .c file that has the original definition?
Otherwise the definition and the declaration can get out of sync without notice.

	Sam

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

[Roland Dreier]

the patch looks fine except your mailer seems to have mangled
it... can you resend so I can apply it?

thanks...

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

[Hoang-Nam Nguyen]

Hi Roland!
> the patch looks fine except your mailer seems to have mangled
> it... can you resend so I can apply it?
Was going to recreate this patch, but then I saw that you
probably have incorporated it (manually) in your latest git.
Just want to make sure I'm seeing it right.
Anyway, appreciate your help!
Nam

Re: [ofa-general] [PATCH 1/2] ehca: remove checkpatch.pl's warnings "externs should be avoided in .c files"

[Roland Dreier]

 > Was going to recreate this patch, but then I saw that you
 > probably have incorporated it (manually) in your latest git.
 > Just want to make sure I'm seeing it right.

Yes, I ended up doing it by hand.  Thanks.