From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sj-iport-4.cisco.com (sj-iport-4.cisco.com [171.68.10.86]) by ozlabs.org (Postfix) with ESMTP id 7379D67DE5 for ; Tue, 14 Nov 2006 03:40:02 +1100 (EST) To: Paul Mackerras Subject: Re: [openib-general] [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode References: <17748.15442.906060.210242@cargo.ozlabs.ibm.com> From: Roland Dreier Date: Mon, 13 Nov 2006 08:39:58 -0800 In-Reply-To: <17748.15442.906060.210242@cargo.ozlabs.ibm.com> (Paul Mackerras's message of "Fri, 10 Nov 2006 19:46:10 +1100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org, openib-general-bounces@openib.org, Christoph Raisch , linux-kernel@vger.kernel.org, openib-general@openib.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > > The patch is needed. We've seen it on the real system. We did fix it on the > > real system. > > I disagree that the ioremap change is needed. Hmm... Paul, what you say makes sense and is what I would have thought, but Christoph says that the unpatched code really fails on a real system. So I'm still confused. I think I'll merge this with a fat comment, with the hope that we can drop it ASAP once everyone agrees on what's going on. - R.