From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sj-iport-6.cisco.com (sj-iport-6.cisco.com [171.71.176.117]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "sj-iport-6.cisco.com", Issuer "Cisco SSCA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 733BFDEC04 for ; Thu, 21 Aug 2008 02:33:17 +1000 (EST) From: Roland Dreier To: jwboyer@linux.vnet.ibm.com Subject: Re: [PATCH 1/9] powerpc/44x: Add PowerPC 44x simple platform support References: <496103659f7b122a8301703b055ef4c6bd3092af.1219160188.git.jwboyer@linux.vnet.ibm.com> <200808201533.22258.arnd@arndb.de> <1219243548.26429.25.camel@jdub.homelinux.org> Date: Wed, 20 Aug 2008 09:33:06 -0700 In-Reply-To: <1219243548.26429.25.camel@jdub.homelinux.org> (Josh Boyer's message of "Wed, 20 Aug 2008 10:45:47 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org, Arnd Bergmann List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > You should fix 52xx with the same for loop change then, since I > blatantly most of this file from you ;) Heh, then factor out mpc5200_simple_probe() into a helper and use it instead of copying it as ppc44x_probe? ;) If you stick to the NULL-terminated array version, then it becomes easy to convert some other platform probing code to use your new code too, eg tqm85xx_probe() could use an array too. - R.