From: Roland Dreier <rdreier@cisco.com>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
openib-general@openib.org, raisch@de.ibm.com
Subject: Re: [PATCH 2.6.19] ehca: bug fix: use wqe offset instead wqe address to determine pending work requests
Date: Wed, 22 Nov 2006 15:04:01 -0800 [thread overview]
Message-ID: <adaslgbaxsu.fsf@cisco.com> (raw)
In-Reply-To: <200611221029.10077.hnguyen@linux.vnet.ibm.com> (Hoang-Nam Nguyen's message of "Wed, 22 Nov 2006 10:29:09 +0100")
> We found this bug actually through a code review by random. Since
> (un)fortunately the queue pages were layouted in order, we've not
> seen it earlier. It's certainly a bug and can cause kernel panic
> if above observation is not met, probably in stress situation
> of system. That means the "former" code accesses next page that
> it has not allocated.
OK. After thinking about this, I'm going to queue it for 2.6.20 --
we're _way_ too close to the 2.6.19 final release to put in patches
that aren't either small and obvious, or fix a problem someone hit in
real life.
- R.
next prev parent reply other threads:[~2006-11-22 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 22:54 [PATCH 2.6.19] ehca: bug fix: use wqe offset instead wqe address to determine pending work requests Hoang-Nam Nguyen
2006-11-21 16:47 ` Roland Dreier
2006-11-22 9:29 ` Hoang-Nam Nguyen
2006-11-22 23:04 ` Roland Dreier [this message]
2006-11-23 13:31 ` Hoang-Nam Nguyen
2006-11-24 23:07 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaslgbaxsu.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=hnguyen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).