linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
	linuxppc-dev@ozlabs.org, raisch@de.ibm.com
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
Date: Mon, 06 Nov 2006 08:50:44 -0800	[thread overview]
Message-ID: <adaslgwo6xn.fsf@cisco.com> (raw)
In-Reply-To: <200611060045.59074.arnd@arndb.de> (Arnd Bergmann's message of "Mon, 6 Nov 2006 00:45:58 +0100")

 > I'd simply move the memset into the alloc function and get rid of the
 > constructor here.

Slightly better still would be to use kmem_cache_zalloc() (save a tiny
bit of text by getting rid of the call to memset).

 - R.

  parent reply	other threads:[~2006-11-06 16:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-05 20:40 [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode Hoang-Nam Nguyen
2006-11-05 23:45 ` Arnd Bergmann
2006-11-06 10:00   ` Hoang-Nam Nguyen
2006-11-06 10:39   ` Hoang-Nam Nguyen
2006-11-06 16:51     ` Roland Dreier
2006-11-06 17:45       ` Hoang-Nam Nguyen
2006-11-06 16:50   ` Roland Dreier [this message]
2006-11-06 14:58 ` Heiko Carstens
2006-11-06 16:13   ` Hoang-Nam Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2006-11-06 21:26 Hoang-Nam Ngyuen
2006-11-06 21:35 ` Arnd Bergmann
2006-11-06 23:56   ` Hoang-Nam Ngyuen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaslgwo6xn.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=openib-general@openib.org \
    --cc=raisch@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).