From: Roland Dreier <rdreier@cisco.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linuxppc-dev@ozlabs.org, Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: mal_probe crash
Date: Fri, 09 Jan 2009 14:01:45 -0800 [thread overview]
Message-ID: <aday6xknnp2.fsf@cisco.com> (raw)
In-Reply-To: <1231536613.2142.74.camel@pasglop> (Benjamin Herrenschmidt's message of "Sat, 10 Jan 2009 08:30:13 +1100")
> Can you double check that the e1000 isn't copying the PCI resources into
> a unsigned long before ioremap'ing the result, thus cropping the top
> bits ?
as far as I can see, e1000 is using pci_ioremap_bar(), which should do
the right thing as long as resource_size_t is the right type (which it
looks like it is on PowerPC 44x).
- R.
next prev parent reply other threads:[~2009-01-09 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 20:44 mal_probe crash Sean MacLennan
2009-01-08 20:46 ` Josh Boyer
2009-01-07 22:50 ` Benjamin Herrenschmidt
2009-01-09 14:42 ` Geert Uytterhoeven
2009-01-09 22:34 ` Herbert Xu
2009-01-09 23:13 ` Benjamin Herrenschmidt
2009-01-09 14:49 ` Matthias Fuchs
2009-01-09 15:02 ` Matthias Fuchs
2009-01-09 15:24 ` Geert Uytterhoeven
2009-01-09 21:30 ` Benjamin Herrenschmidt
2009-01-09 22:01 ` Roland Dreier [this message]
2009-01-12 13:37 ` Geert Uytterhoeven
2009-01-12 21:36 ` Benjamin Herrenschmidt
2009-01-12 22:48 ` Josh Boyer
2009-01-12 22:51 ` Re[2]: " Yuri Tikhonov
2009-01-13 2:52 ` Benjamin Herrenschmidt
2009-01-13 16:19 ` Geert Uytterhoeven
2009-01-09 21:09 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aday6xknnp2.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).