From: Roland Dreier <rdreier@cisco.com>
To: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
openib-general@openib.org, raisch@de.ibm.com
Subject: Re: [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode
Date: Tue, 07 Nov 2006 11:25:12 -0800 [thread overview]
Message-ID: <aday7qngiuf.fsf@cisco.com> (raw)
In-Reply-To: <200611052141.29030.hnguyen@de.ibm.com> (Hoang-Nam Nguyen's message of "Sun, 5 Nov 2006 21:41:28 +0100")
> - *mapaddr = (u64)(ioremap(physaddr, EHCA_PAGESIZE));
> + *mapaddr = (u64)ioremap((physaddr & PAGE_MASK), PAGE_SIZE) +
> + (physaddr & (~PAGE_MASK));
I'm confused -- shouldn't ioremap() do the right thing even if
physaddr isn't page-aligned? Why is this needed?
- R.
next prev parent reply other threads:[~2006-11-07 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 20:41 [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode Hoang-Nam Nguyen
2006-11-07 19:25 ` Roland Dreier [this message]
2006-11-08 10:22 ` Christoph Raisch
2006-11-08 22:06 ` Roland Dreier
2006-11-09 6:36 ` Paul Mackerras
2006-11-09 21:58 ` Roland Dreier
2006-11-10 7:49 ` [openib-general] " Christoph Raisch
2006-11-10 8:46 ` Paul Mackerras
2006-11-13 16:39 ` Roland Dreier
2006-11-13 16:40 ` Christoph Raisch
2006-11-13 16:40 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aday7qngiuf.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=hnguyen@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).