From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CADC7E64001 for ; Sun, 12 Apr 2026 08:56:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ftktQ6YsSz2ynh; Sun, 12 Apr 2026 18:56:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::42b" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775984206; cv=none; b=Z3IfRxhX82Oo3mOMs2WUs5IcwxsX+texUs2wi0SreBYpjM7sEZAt7aL45AhVBqteKqaumNZFuQOR7o62SS3wUcaRyreGo7eyIJVv+Fjnk1DoGarHlYzgicuhV/sCnL9Ab7ngXAm6ckanYG27TroCJUAj9E/zsZJMdyVO6YgCMNzDEuc79whdDEHGG0bLfj3mbCtXqmIaVln+58I0x8qxn4P+7e/0EoGTiFtZPpzwziNkuj7zL/jaWD1TxzkXFn1foIwiUHTPLXwMMOqgflTUaEX/aHoDaRJ+DP9Nb823uIJnVlUfw7eU7fZ5MEV9RLqkMHPRbpy8kP4yMzpBWPY0ZA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775984206; c=relaxed/relaxed; bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DYTV5sCfJfxS8EtrcFN9W0iYry7m7whBlR5Qil/zwlP2IqPCbl+SLlYieQWh7uBljhNOoHMb7S5/UtOXTFzZQk2YrET1EzBAj5xx1nr2JLy5BQajS32sfjofFg2GQZjUV8RUjQdfjMVrn7hNbhElmBFwRqPEukeo+XnIXxRpzI3XYIMwew3GTXGpVYsk9UGPmPHfe0pJU//VbzUUbKptdALxmejufVjWJ3ZpTxBH+Y+PYZbOGsF2+OnvpZujt1QmU6I5dZKDz7c5ZfmVffR7y7Wl5zvUTKGyDmvL0k8wG3AwLeK/xBanYgChxS+7lmVFbEI4KEhG0DxWhNkkJkUEAw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=IupEoFTz; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com; envelope-from=shorne@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=IupEoFTz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com; envelope-from=shorne@gmail.com; receiver=lists.ozlabs.org) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ftktP0F87z2yng for ; Sun, 12 Apr 2026 18:56:44 +1000 (AEST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-43d75312379so133520f8f.1 for ; Sun, 12 Apr 2026 01:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775984196; x=1776588996; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=; b=IupEoFTzVgScv1B4jNJJeSZYkRJAjDRpAhQZUmHA+4XVLql9iHp1pyBcC5f/G1Gw1E HgFoA9CUKP3MWdH6hvklTlUNXM5VC+QX9MJGtNsli/pDPeS65smWXBcYs4YGEJxuTi6i LBIlhjjwo+h7tiC2fvZ47PwMLCchCYhe8TVAyR3Oj4FrlTUc7xZ/5o4xEFtD/T0VgYt4 n1DyEeOyu48q5qtlsCiHPgPBpx6YQlBvQIYD8o0rT+/ivPguxoKC60Yroc3LMlykzC+0 yeFsPTYfTNd2eIYkP5F/cSnkWqL4okT8Y3MqTh/lhZLMq8wkhV7nPcjJ1E/ddgEWpb2k 3rEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775984196; x=1776588996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=; b=fLIhms6gYksTuxnAHvPe+g0MjgzRu63vS3HuWSVfaYdmKGwtPhMJI5gax+YgQmFRKt wqtB/xjtJyeBzzyDKF+dTDrRnqnXHfp0+t6RZndfQpF0UMYcbTjNH24j06SKe437TiZ5 ExaXSZJAKjiK/6kyp2bEcdFcA7o2cvVSVf1toQGZpzJEZVNWpFcZXJ2K+PgMJSbYhIoX cz91G1u+7hiRzsF6NyKHDDPcfMyVcP+UNZ8cVVZz0gfJO3VOhXlWxCE70aq4TgsMykuc nDty5z2yTIgHJWu24i3HrahV5C9UXfaa6/1Eq0neZPsGq5eoC9VMep8LpSMv8Tr5MyBS qHRQ== X-Forwarded-Encrypted: i=1; AJvYcCWImZRwfEbH55/uFw0LwOJfNUjyCyCBMCLBLCk402f08ZVstbu6RHdyuundNOBotNnVAKNUeWZ6lbp7bSs=@lists.ozlabs.org X-Gm-Message-State: AOJu0YyWMGsrtbpnf1UqP71SfudODsZxfAY3yP63PEZzQmodNJQI0xHz jyvlmBd63RDms6tqqXnJEt9xGY/5BwQ+Hso2PKoXaog5eAmYtiTl801n X-Gm-Gg: AeBDieucooeeNNrQ4nfZTaOvEm62Dwgml2hxz7fx1jbA8Cp3tS3FYxVfne9udLbRd3j wHkqINWv6eXAy85LcYvXhTfILzkvdqhYL5EkW+2DHvb/CXgLXG2zxfxFHKnNSO+eKtiGXNpXRui G5Ev6ZRNnZHJsnbBHdNCLJdUxu25PUOraVd4BIFBIwCiujPfG1SVacK7yltEYm8mmsLRpjzbT2u tb22EmGwJug193mcexLRo3KCv2El3ANDObhDYG03E2xlyU8gSIBpfWw6ymMt8OKNbWhbCTFvT8j M91un2xQW/HqUwiMCqZIgWJMOXlRrVerBF4ELP4KgT+fh1JYxf6+TgKFCj2dAJtLahggsRNj6v/ BsOrHOPl/t9K+gaU7o2gQ86ESxgYJ6Rt7fMCXqyC9gjRH3og8GvBzcaPsXTicpG/uEJhBuWDUia Um6DM63lxPfSdu6PHQIrOa/sdueGy8xFcANFPpROFawtCUPsE5rB3NjvhSSjRxouqZVJ7RhOxwO kbjYg== X-Received: by 2002:a05:600c:698d:b0:487:22ad:403e with SMTP id 5b1f17b1804b1-488d6ac9ce5mr126951995e9.14.1775984195334; Sun, 12 Apr 2026 01:56:35 -0700 (PDT) Received: from localhost (brnt-04-b2-v4wan-170138-cust2432.vm7.cable.virginm.net. [94.175.9.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d532ed4dsm197923925e9.4.2026.04.12.01.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 01:56:34 -0700 (PDT) Date: Sun, 12 Apr 2026 09:56:33 +0100 From: Stafford Horne To: Thomas Gleixner Cc: LKML , Jonas Bonn , linux-openrisc@vger.kernel.org, Arnd Bergmann , x86@kernel.org, Lu Baolu , iommu@lists.linux.dev, Michael Grzeschik , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Herbert Xu , linux-crypto@vger.kernel.org, Vlastimil Babka , linux-mm@kvack.org, David Woodhouse , Bernie Thompson , linux-fbdev@vger.kernel.org, Theodore Tso , linux-ext4@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Thomas Sailer , linux-hams@vger.kernel.org, "Jason A. Donenfeld" , Richard Henderson , linux-alpha@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Huacai Chen , loongarch@lists.linux.dev, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Dinh Nguyen , Helge Deller , linux-parisc@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Paul Walmsley , linux-riscv@lists.infradead.org, Heiko Carstens , linux-s390@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: [patch 30/38] openrisc: Select ARCH_HAS_RANDOM_ENTROPY Message-ID: References: <20260410120044.031381086@kernel.org> <20260410120319.593798781@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410120319.593798781@kernel.org> On Fri, Apr 10, 2026 at 02:20:55PM +0200, Thomas Gleixner wrote: > The only remaining non-architecture usage of get_cycles() is to provide > random_get_entropy(). > > Switch openrisc over to the new scheme of selecting ARCH_HAS_RANDOM_ENTROPY > and providing random_get_entropy() in asm/random.h. > > Add 'asm/timex.h' includes to the relevant files, so the global include can > be removed once all architectures are converted over. > > Signed-off-by: Thomas Gleixner > Cc: Jonas Bonn > Cc: linux-openrisc@vger.kernel.org This looks good to me. Acked-by: Stafford Horne > --- > arch/openrisc/Kconfig | 1 + > arch/openrisc/include/asm/random.h | 12 ++++++++++++ > arch/openrisc/include/asm/timex.h | 5 ----- > arch/openrisc/lib/delay.c | 1 + > 4 files changed, 14 insertions(+), 5 deletions(-) > > --- a/arch/openrisc/Kconfig > +++ b/arch/openrisc/Kconfig > @@ -10,6 +10,7 @@ config OPENRISC > select ARCH_HAS_DELAY_TIMER > select ARCH_HAS_DMA_SET_UNCACHED > select ARCH_HAS_DMA_CLEAR_UNCACHED > + select ARCH_HAS_RANDOM_ENTROPY > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > select GENERIC_BUILTIN_DTB > select COMMON_CLK > --- /dev/null > +++ b/arch/openrisc/include/asm/random.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#ifndef __ASM_OPENRISC_RANDOM_H > +#define __ASM_OPENRISC_RANDOM_H > + > +#include > + > +static inline unsigned long random_get_entropy(void) > +{ > + return get_cycles(); > +} > + > +#endif > --- a/arch/openrisc/include/asm/timex.h > +++ b/arch/openrisc/include/asm/timex.h > @@ -9,13 +9,9 @@ > * OpenRISC implementation: > * Copyright (C) 2010-2011 Jonas Bonn > */ > - > #ifndef __ASM_OPENRISC_TIMEX_H > #define __ASM_OPENRISC_TIMEX_H > > -#define get_cycles get_cycles > - > -#include > #include > #include > > @@ -23,6 +19,5 @@ static inline cycles_t get_cycles(void) > { > return mfspr(SPR_TTCR); > } > -#define get_cycles get_cycles > > #endif > --- a/arch/openrisc/lib/delay.c > +++ b/arch/openrisc/lib/delay.c > @@ -18,6 +18,7 @@ > #include > > #include > +#include > #include > > bool delay_read_timer(unsigned long *timer_value) > >