linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
To: mpe@ellerman.id.au, aneesh.kumar@linux.vnet.ibm.com,
	bsingharora@gmail.com, linuxppc-dev@lists.ozlabs.org
Cc: alistair@popple.id.au, clombard@linux.vnet.ibm.com,
	vaibhav@linux.vnet.ibm.com
Subject: Re: [PATCH v3 0/3] powerpc/mm: Mark memory contexts requiring global TLBIs
Date: Wed, 30 Aug 2017 15:29:46 +0200	[thread overview]
Message-ID: <ae594759-8c07-81e1-5890-6be68ef068d8@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170802202930.5616-1-fbarrat@linux.vnet.ibm.com>

I'm dropping this series, as there was a recent change done in the 
memory context that I can reuse.
The follow up of the story is:
http://patchwork.ozlabs.org/patch/807570/

   Fred


Le 02/08/2017 à 22:29, Frederic Barrat a écrit :
> capi2 and opencapi require the TLB invalidations being sent for
> addresses used on the cxl adapter or opencapi device to be global, as
> there's a translation cache in the PSL (for capi2) or NPU (for
> opencapi). The CAPP, on behalf of the PSL, and NPU snoop the power bus.
> 
> This is not new: for the hash memory model, as soon as the cxl driver
> is active, all local TLBIs become global. We need a similar mechanism
> for the radix memory model. This patch tries to improve things a bit
> by flagging the contexts requiring global TLBIs, therefore limiting
> the "upgrade" and not affecting contexts not used by the card.
> 
> A longer-term goal is to modify the current implementation for hash to
> follow the same direction, i.e. identify contexts needing global
> TLBIs, but that will be for later. It would be required to support
> hash for opencapi.
> 
> Changelog:
> v3:
>   - convert from RFC to PATCH
>   - mark contexts used by XSL (cxllib) as needed global invalidation
> RFC v2:
>   - address comments received
>   - rename MM_CONTEXT_GLOBAL_TLBI -> MM_GLOBAL_TLBIE
>   - add memory barriers to make sure the device doesn't miss any TLBI
>   - also add barrier for the hash implemention to fix the same issue
> 
> Frederic Barrat (3):
>    powerpc/mm: Add marker for contexts requiring global TLB invalidations
>    cxl: Mark context requiring global TLBIs
>    cxl: Add memory barrier to guarantee TLBI scope
> 
>   arch/powerpc/include/asm/book3s/64/mmu.h | 18 ++++++++++++++++++
>   arch/powerpc/include/asm/tlb.h           | 27 +++++++++++++++++++++++----
>   arch/powerpc/mm/mmu_context_book3s64.c   |  1 +
>   arch/powerpc/mm/tlb-radix.c              |  8 ++++----
>   arch/powerpc/mm/tlb_hash64.c             |  3 ++-
>   drivers/misc/cxl/api.c                   | 12 ++++++++++--
>   drivers/misc/cxl/cxllib.c                |  7 +++++++
>   drivers/misc/cxl/file.c                  | 12 ++++++++++--
>   include/misc/cxl-base.h                  | 22 +++++++++++++++++++---
>   9 files changed, 94 insertions(+), 16 deletions(-)
> 

      parent reply	other threads:[~2017-08-30 13:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 20:29 [PATCH v3 0/3] powerpc/mm: Mark memory contexts requiring global TLBIs Frederic Barrat
2017-08-02 20:29 ` [PATCH v3 1/3] powerpc/mm: Add marker for contexts requiring global TLB invalidations Frederic Barrat
2017-08-03  7:16   ` Balbir Singh
2017-08-22  3:11     ` Alistair Popple
2017-08-02 20:29 ` [PATCH v3 2/3] cxl: Mark context requiring global TLBIs Frederic Barrat
2017-08-03  7:22   ` Balbir Singh
2017-08-22  3:09     ` Alistair Popple
2017-08-02 20:29 ` [PATCH v3 3/3] cxl: Add memory barrier to guarantee TLBI scope Frederic Barrat
2017-08-30 13:29 ` Frederic Barrat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae594759-8c07-81e1-5890-6be68ef068d8@linux.vnet.ibm.com \
    --to=fbarrat@linux.vnet.ibm.com \
    --cc=alistair@popple.id.au \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bsingharora@gmail.com \
    --cc=clombard@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=vaibhav@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).