From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, anton@samba.org
Subject: Re: [PATCH] powerpc/pseries: hcall_exit tracepoint retval should be signed
Date: Wed, 9 May 2018 15:16:09 +0530 [thread overview]
Message-ID: <ae859b3b-6de9-dcc0-7976-deaec9f23bdd@linux.ibm.com> (raw)
In-Reply-To: <20180507130355.25115-1-mpe@ellerman.id.au>
On 05/07/2018 06:33 PM, Michael Ellerman wrote:
> The hcall_exit() tracepoint has retval defined as unsigned long. That
> leads to humours results like:
>
> bash-3686 [009] d..2 854.134094: hcall_entry: opcode=24
> bash-3686 [009] d..2 854.134095: hcall_exit: opcode=24 retval=18446744073709551609
>
> It's normal for some hcalls to return negative values, displaying them
> as unsigned isn't very helpful. So change it to signed.
>
> bash-3711 [001] d..2 471.691008: hcall_entry: opcode=24
> bash-3711 [001] d..2 471.691008: hcall_exit: opcode=24 retval=-7
>
> Which can be more easily compared to H_NOT_FOUND in hvcall.h
Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Thank,
Ravi
next prev parent reply other threads:[~2018-05-09 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 13:03 [PATCH] powerpc/pseries: hcall_exit tracepoint retval should be signed Michael Ellerman
2018-05-08 11:57 ` Anton Blanchard
2018-05-09 9:46 ` Ravi Bangoria [this message]
2018-05-10 14:06 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae859b3b-6de9-dcc0-7976-deaec9f23bdd@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).