From: Magnus Damm <magnus.damm@gmail.com>
To: linuxppc-dev@ozlabs.org, linuxppc-embedded@ozlabs.org
Subject: [PATCH] drivers/ide/ppc/mpc8xx.c - volatile fix
Date: Sat, 11 Dec 2004 15:48:07 +0100 [thread overview]
Message-ID: <aec7e5c304121106482fcdba62@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
Hello,
I fixed this in a local tree for a customer half a year ago (mvl-3.1)
and forgot to report it to the lists. Now I came across it in vanilla
2.5.10-rc3. I have not tested the fix but it is pretty obvious that
access with a non-volatile pointer to hardware is bad, at least with
gcc-3 or above.
Please apply. Or ignore if already fixed. =)
Thanks.
/ magnus (needs CC)
[-- Attachment #2: linux-2.6.9-mpc8xx-volatile.patch --]
[-- Type: application/octet-stream, Size: 377 bytes --]
--- linux-2.6.9/drivers/ide/ppc/mpc8xx.c 2004-12-11 13:05:09.000000000 +0100
+++ linux-2.6.9-mpc8xx-volatile/drivers/ide/ppc/mpc8xx.c 2004-12-11 15:49:16.000000000 +0100
@@ -172,7 +172,7 @@
volatile pcmcia_win_t *win;
volatile pcmconf8xx_t *pcmp;
- uint *pgcrx;
+ volatile uint *pgcrx;
u32 pcmcia_phy_base;
u32 pcmcia_phy_end;
static unsigned long pcmcia_base = 0;
reply other threads:[~2004-12-11 14:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c304121106482fcdba62@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).