From: Geoff Levand <geoff@infradead.org>
To: Christoph Hellwig <hch@lst.de>, jim@jtan.com
Cc: linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ps3vram: remove bio splitting
Date: Mon, 23 Jan 2023 17:41:15 -0800 [thread overview]
Message-ID: <aed3d64e-1209-0a28-2337-8d40b1a78d6c@infradead.org> (raw)
In-Reply-To: <20230123074718.57951-1-hch@lst.de>
Hi Christoph,
On 1/22/23 23:47, Christoph Hellwig wrote:
> ps3vram iterates over the bio one segment, that is page aligned and max
> page sized chunk, a time. Because of that there is no point in
> calling bio_split_to_limits, or explicitly setting the default limits
> that are only used by bio_split_to_limits.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/block/ps3vram.c | 7 -------
> 1 file changed, 7 deletions(-)
I tested this patch applied to the ps3-queue branch (v6.2-rc5 based) of my
kernel.org ps3-linux repo. I could format the ps3vram device with ext4,
copy files to it, run fsck, etc.
Thanks for your effort.
Tested-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2023-01-24 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 7:47 [PATCH] ps3vram: remove bio splitting Christoph Hellwig
2023-01-24 1:41 ` Geoff Levand [this message]
2023-01-24 2:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aed3d64e-1209-0a28-2337-8d40b1a78d6c@infradead.org \
--to=geoff@infradead.org \
--cc=hch@lst.de \
--cc=jim@jtan.com \
--cc=linux-block@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).