From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 237A5C25B50 for ; Tue, 24 Jan 2023 01:42:39 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P18qK2W5sz3cFN for ; Tue, 24 Jan 2023 12:42:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Sy5NNZHy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=geoff@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=Sy5NNZHy; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P18pC60cnz2yw6 for ; Tue, 24 Jan 2023 12:41:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=1g8rJeVMlQ/HySUMtGPrVNB0AVWPc1UPUlwjLl3cAdM=; b=Sy5NNZHyXuEe14owLQ1OGzg5x3 DIxOoJ0QtvWVGGOhiI1vhn8D5oYjnR2YEMwKAxquhpyfx1eLYjMVKYqEoptzL0ju8zDpQdltw/CA1 gJ8bZCaZZOliHlpnkxEfk9/BHkYBwgn3NzdInqtZYcfui+aDyuFQjVlIEexo01Vr33id8796heQXM d/O4OPNtgCMRnPOPeKhhDOj/58XeV7JyEfVXAYdKAztN9fsXoxZ0hvLQnqk4e2pWG/6hbkdOxCWAT SCrim9G5GIrLg7EHc6K94AwaHQbrtilouBb+ilRDjUzmrJV0nSteYlSckRKpyFYWOeW2QeixCZMsY t4418MKw==; Received: from 108-90-42-56.lightspeed.sntcca.sbcglobal.net ([108.90.42.56] helo=[192.168.1.80]) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK8JM-004gKO-Tk; Tue, 24 Jan 2023 01:41:21 +0000 Message-ID: Date: Mon, 23 Jan 2023 17:41:15 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] ps3vram: remove bio splitting To: Christoph Hellwig , jim@jtan.com References: <20230123074718.57951-1-hch@lst.de> Content-Language: en-US From: Geoff Levand In-Reply-To: <20230123074718.57951-1-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christoph, On 1/22/23 23:47, Christoph Hellwig wrote: > ps3vram iterates over the bio one segment, that is page aligned and max > page sized chunk, a time. Because of that there is no point in > calling bio_split_to_limits, or explicitly setting the default limits > that are only used by bio_split_to_limits. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/ps3vram.c | 7 ------- > 1 file changed, 7 deletions(-) I tested this patch applied to the ps3-queue branch (v6.2-rc5 based) of my kernel.org ps3-linux repo. I could format the ps3vram device with ext4, copy files to it, run fsck, etc. Thanks for your effort. Tested-by: Geoff Levand