From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7733CCF9E0 for ; Fri, 24 Oct 2025 13:23:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4ctNs41cH3z30RJ; Sat, 25 Oct 2025 00:23:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1761312232; cv=none; b=SqvURn8ViEGfZZLyYtDiSUVAK7L/YC013jBPC2ePWyRYaKbt55bsx1KuUvnoxRPp4vstM523xcRticTtR/aTM9JcxE5YbP83PyRu9xifBwTQ02AGVhuhfagHfLBzCIHMoj85elsQw3t6rHdbQE3egyctJd2rh9eu4cH5Spxzkj0r4yFgcOr4D7T8DOiS3dazU3wRRGVfY+5eHRSVZ8tfLlMH0M4AUzDOpVeDPTk5cJQ0dK8c/JwTbx8Rw9ShEngqPNnc3lKdGzqvLhbrBlaYAWna/RqNLVufr246ppurIoa/IifV18t5Z9NgHZKhPxpFxOWKkls4hWUZf1/35Oghww== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1761312232; c=relaxed/relaxed; bh=9pZe05cqV5Y1PIBh8vBXPAYdFpy0cqXi9nRKa9E+n1Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NzzV7yc9CKbglK+OD3XVy2Zpb2VAklBaqFfX0Bh9cEjo80ij4CLRcUEQCg0bhmYNSjFbfjxm/YaXACpn97brKzHblHRXB/wkiMyVj+PcH1Qc3+GdFGS+6uWnYauvOrN21pokO03XHNCAYSiLfQ33FTupgf0KoYm5URBVhq5g9qYdmDUGumWO0f4rymV+Jum+hBYnmKl/r1EHHE/SdDiiGNEcsovf14T1ayqIbWJeJv+P81z2cwshZXQjJyQrQphX6I2WLrlRTzzAPfKRVm4mgDY2+Hb98r5bDii/y3LnWwD2PhCdhb04p3ouzmxAfhFgIkNK8f9KkBAbV6qWPWAF1Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MSchdtg/; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MSchdtg/; dkim-atps=neutral; spf=pass (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MSchdtg/; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MSchdtg/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ctNs30dRKz2xK5 for ; Sat, 25 Oct 2025 00:23:49 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761312226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9pZe05cqV5Y1PIBh8vBXPAYdFpy0cqXi9nRKa9E+n1Q=; b=MSchdtg/4j+KLaSKgcGfRjOZVIXPvyc+npI9oIgPWGV8UaK6J2Z5wEmXpLLwx5miJ7q0UL OFKroxe4Gc7Lv2rXp0wb7nrh8/s9uMjplzJisTOSHF6iUXNyFSEswDk+PlKByT6H5v9aJ6 UcK5eNguq/FUvShLuFruAyvLD5cqkmc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761312226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9pZe05cqV5Y1PIBh8vBXPAYdFpy0cqXi9nRKa9E+n1Q=; b=MSchdtg/4j+KLaSKgcGfRjOZVIXPvyc+npI9oIgPWGV8UaK6J2Z5wEmXpLLwx5miJ7q0UL OFKroxe4Gc7Lv2rXp0wb7nrh8/s9uMjplzJisTOSHF6iUXNyFSEswDk+PlKByT6H5v9aJ6 UcK5eNguq/FUvShLuFruAyvLD5cqkmc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-ScYxrdvyMfeuC43bbWjGHg-1; Fri, 24 Oct 2025 09:23:44 -0400 X-MC-Unique: ScYxrdvyMfeuC43bbWjGHg-1 X-Mimecast-MFC-AGG-ID: ScYxrdvyMfeuC43bbWjGHg_1761312223 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e39567579so10173075e9.0 for ; Fri, 24 Oct 2025 06:23:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761312223; x=1761917023; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9pZe05cqV5Y1PIBh8vBXPAYdFpy0cqXi9nRKa9E+n1Q=; b=fcm21mb1LhqLD1MgpKXLLh5nDwtava5eG4am5Ea7C5tpKat1FJfd+HbPN2IGlNwOjk tOkZczIiw+GCEXUKq/HJIma/BxW3mKC9wtJZ1w2F/2jewxsDn5eKXHn5BJaX0LkEyqPz nwJ76AkqjKi8tHD+w6QZCBTIKiHFUkzOZ0rj2Yxj8o9RXPc9a/OO5vF8PI4TPJ1FsUMf a9axaYpk6kGiH7lFCQXW/Z/1S2wEKeJVp7TK54CriCe2LvscjPV3U2oSSBN7R9QBgIj3 7sxLAg4Um4ZvCxNaRtmumuwtuWCH0TszdcznxtfWwA2/5AO1kWn6lagptWykShWUREKK uaVA== X-Forwarded-Encrypted: i=1; AJvYcCXlIllSOE5+Rs6utB6En/9Nb2XkjD1H4RqZe7Tl42NtFUflLNfWBuZo/nVVLCtLbbfDLxm+8mmUv4llB8c=@lists.ozlabs.org X-Gm-Message-State: AOJu0YxO10jtWSdfRQvHr46y81D+8BWhIMMLPCp5RQ0LH5RUxOiNB+Os VeJ/Mcx+lfBhJglHlKVFXZtIRiHYQASKmQvXed3mLWl9Q/pI0RHaXsjIe1ixgreyF44Mg09Ucb2 ssoXp2SIjWHzdNZ2D5+ivJIcl+gzjC0W7undD05LT4PrRQAL4MXQH5EQVlw2xEjV7dWs= X-Gm-Gg: ASbGncuvGbaQYPb2lRVaUZS7QJp+pJQ/uWLr9pTvD5F++gr3nnAYZu3EsSn5c7A7BWy zEadU8FOTkC56+K4wgqok1sB68JO1JLPeVPej2ze5FqUYEhjactRv7NTUWwT4NchofmN8xwB35J 3Ix9PtbDzQCD87vJBznAk2cHjE22egIcNMaXSfeTmJerTbxBQGIg+rHpbxKEzXTulVtRZQCtPsr PPnoJK0nOljmIARIgUEcSquf4nuML7lBqWFOg+ynifM4BAzxsVDOyPSxd4UnS13qRnZMcfliPWL reXVmqEd91CVoe38MFABU8JUs5SRVuU5b3MRt3S5DtqUqS8VAq9gRr62yzL83n3kqBFW1nWiqpz cvgmjUYb0XX3ar9hetnZ0L+spBqG9mwm/wuCF/nmqOMJ6qTBI4Q0PhqevkwcDf6TVcod4ntbNWy WiaotiQ40MYmMBUHWaS2+XD+bSqns= X-Received: by 2002:a05:600c:1d9b:b0:46e:38f7:625f with SMTP id 5b1f17b1804b1-471178771b6mr180789355e9.10.1761312223041; Fri, 24 Oct 2025 06:23:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtGsLBVTNfj/FZoaJq9YDf0YbzbT70oZVwx4vja/yfyCx4XWjsWfYr2kPeTBeEcFsrMCFiZA== X-Received: by 2002:a05:600c:1d9b:b0:46e:38f7:625f with SMTP id 5b1f17b1804b1-471178771b6mr180789265e9.10.1761312222639; Fri, 24 Oct 2025 06:23:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898ec1dfsm9461004f8f.43.2025.10.24.06.23.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 06:23:42 -0700 (PDT) Message-ID: Date: Fri, 24 Oct 2025 15:23:39 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/13] mm: enable lazy_mmu sections to nest To: Kevin Brodsky , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20251015082727.2395128-1-kevin.brodsky@arm.com> <20251015082727.2395128-8-kevin.brodsky@arm.com> <2073294c-8003-451a-93e0-9aab81de4d22@redhat.com> <7a4e136b-66a5-4244-ab07-f0bcc3a26a83@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <7a4e136b-66a5-4244-ab07-f0bcc3a26a83@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sICH237WIKh3V1byiwmDagE1h07E0qiv_8EM5tsIem4_1761312223 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >>> + * currently enabled. >>>    */ >>>   #ifdef CONFIG_ARCH_LAZY_MMU >>>   static inline void lazy_mmu_mode_enable(void) >>>   { >>> -    arch_enter_lazy_mmu_mode(); >>> +    struct lazy_mmu_state *state = ¤t->lazy_mmu_state; >>> + >>> +    VM_BUG_ON(state->count == U8_MAX); >> >> No VM_BUG_ON() please. > > I did wonder if this would be acceptable! Use VM_WARN_ON_ONCE() and let early testing find any such issues. VM_* is active in debug kernels only either way! :) If you'd want to handle this in production kernels you'd need if (WARN_ON_ONCE()) { /* Try to recover */ } And that seems unnecessary/overly-complicated for something that should never happen, and if it happens, can be found early during testing. > > What should we do in case of underflow/overflow then? Saturate or just > let it wrap around? If an overflow occurs we're probably in some > infinite recursion and we'll crash anyway, but an underflow is likely > due to a double disable() and saturating would probably allow to recover. > >> >>> +    /* enable() must not be called while paused */ >>> +    VM_WARN_ON(state->count > 0 && !state->enabled); >>> + >>> +    if (state->count == 0) { >>> +        arch_enter_lazy_mmu_mode(); >>> +        state->enabled = true; >>> +    } >>> +    ++state->count; >> >> Can do >> >> if (state->count++ == 0) { > > My idea here was to have exactly the reverse order between enable() and > disable(), so that arch_enter() is called before lazy_mmu_state is > updated, and arch_leave() afterwards. arch_* probably shouldn't rely on > this (or care), but I liked the symmetry. I see, but really the arch callback should never have to care about that value -- unless something is messed up :) [...] >>> +static inline bool in_lazy_mmu_mode(void) >> >> So these functions will reveal the actual arch state, not whether >> _enabled() was called. >> >> As I can see in later patches, in interrupt context they are also >> return "not in lazy mmu mode". > > Yes - the idea is that a task is in lazy MMU mode if it enabled it and > is in process context. The mode is never enabled in interrupt context. > This has always been the intention, but it wasn't formalised until patch > 12 (except on arm64). Okay, thanks for clarifying. -- Cheers David / dhildenb