From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6219CD37B6 for ; Wed, 13 May 2026 08:35:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gFmxr2Pv9z2xpt; Wed, 13 May 2026 18:35:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778661344; cv=none; b=i4XK+6Ykvb1Qv1u9BUFad0JOh8c75rSEnclMHSQG325Gf1kbDcHc3fmB40X2TMQy3odhwGVKxvba5HLEeFdYARcK3IsRkWf/qmt70HdjEg7al261JDBYeErDVRkMPOg0CGg4l3Tn67L/8mosYqoY79LtE1NWXOQFcsYRl9wk1E/Wt/k/e8jfu8wiRok16OhCmxsXWt3tQk0dsRTbUOhZu5rZx4Vgxn/Yfv7KKNc66G6lTe8VOKoCDe3mMFLLgVytocO6oHZ+hhMCWIQPe8WG+1CItCNW8H6L1HS7q7JgCfWNkpPObJT7Zyg4+0HSmb7TxQncy3F2RnE27p4mB2CxTg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778661344; c=relaxed/relaxed; bh=OACwkajZ9Nnqo7I89ANtv0rrSw+KZ0m2b0I5x+J1shs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TbnAUHZW8XBs+WcXW6vchqXeuX84mzofNjQOePH72LB6ilIK1UsXO1MXF8rMuqwr2/H1DM1/yABLqFO6fdMqzNJWtXOyw2yiRZMUQ1MJCrsAcoHyhiS7jio0GrNazFoz+AsgL8QWnT4vNYOM2DFx6w+u0okfMPPkAgbTrC7eq6MFjFXGhbAtP9wAV0/vWIyTpl1S28/AqsMT/HIedNP3ufhAPKfhypBzmQk6USawwxPlKjhpmAUpRpkIzzYyYnbgX9Yfhh2ucHdETc3kwEs/dL8n5MFN/1UsKtzIV1VZQhTdOwQU4LDfx1FJOHUIeF69bd+tUE1L9oY2mLSuLmVBoQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=okH5pMZY; dkim-atps=neutral; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=okH5pMZY; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gFmxq3Lb6z2xn3 for ; Wed, 13 May 2026 18:35:43 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 19D42600CB; Wed, 13 May 2026 08:35:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1518CC2BCC7; Wed, 13 May 2026 08:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778661340; bh=CPBNlGo5Ypcm6s7Op2wNhjTQjkcN1uyUXR3OUjk+IQs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=okH5pMZYF+Mu8xh+Bp18k/i22hmItIUH0AM4q7YxBD3srb0B0gNEEHo/y2es9ziUB P9azEwHOLJ0DH8bczP5zmnEIwWO0vX79XmepDrGG7UoJpvGlVkpoY0qhRl1dqc+a0O Gcktb735ASZynglNRgyN6SMjeuQeQQCeWmNeRoEXyrLtqE3GjoBQyzjHtfQIf3N1PZ 4b5LB5SwudTdjISPJMXTTW43zxB4rJKfYYQKmhCHXO6t5pj74HzEzkyUfOryNSzMuk GVoN/WDdHShXVWz4De5OttpPSlXhzZKb/nWBwRDiqycNY7f1XjbrdGxSo3EIgTQQoz 51tMubW8Rqo9Q== Date: Wed, 13 May 2026 11:35:29 +0300 From: Mike Rapoport To: "David Hildenbrand (Arm)" Cc: "David S. Miller" , Andreas Larsson , Andrew Morton , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 5/8] mm/bootmem_info: stop marking the pgdat as NODE_INFO Message-ID: References: <20260511-bootmem_info_prep-v1-0-3fb0be6fc688@kernel.org> <20260511-bootmem_info_prep-v1-5-3fb0be6fc688@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511-bootmem_info_prep-v1-5-3fb0be6fc688@kernel.org> On Mon, May 11, 2026 at 04:05:33PM +0200, David Hildenbrand (Arm) wrote: > We removed the last user of NODE_INFO in commit 119c31caa59e ("mm/sparse: > remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUG"). > > But it really was never used it besides for safety-checks ever since it was > introduced in commit 04753278769f ("memory hotplug: register section/node > id to free"), where we had the comment: > > 5) The node information like pgdat has similar issues. But, this > will be able to be solved too by this. > (Not implemented yet, but, remembering node id in the pages.) > > Of course, that never happened, and we are not planning on freeing the > node data (pgdat/pglist_data), during memory hotunplug. > > So let's just stop marking the pgdat as NODE_INFO. > > Signed-off-by: David Hildenbrand (Arm) Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/bootmem_info.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c > index 74c1116626c8..cce1d560f094 100644 > --- a/mm/bootmem_info.c > +++ b/mm/bootmem_info.c > @@ -62,15 +62,8 @@ static void __init register_page_bootmem_info_section(unsigned long start_pfn) > > void __init register_page_bootmem_info_node(struct pglist_data *pgdat) > { > - unsigned long i, pfn, end_pfn, nr_pages; > + unsigned long pfn, end_pfn; > int node = pgdat->node_id; > - struct page *page; > - > - nr_pages = PAGE_ALIGN(sizeof(struct pglist_data)) >> PAGE_SHIFT; > - page = virt_to_page(pgdat); > - > - for (i = 0; i < nr_pages; i++, page++) > - get_page_bootmem(node, page, NODE_INFO); > > pfn = pgdat->node_start_pfn; > end_pfn = pgdat_end_pfn(pgdat); > > -- > 2.43.0 > -- Sincerely yours, Mike.