From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45BE5CD6E74 for ; Fri, 5 Jun 2026 08:00:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gWv4Z5WmFz2xdb; Fri, 05 Jun 2026 18:00:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780642809; cv=none; b=C9DP+3A98FgmVnsTyQ1295apYS4Lrl7lyvP1jM9F0zXylK79w4mmeJ2RBfsynUoayZlJBvPbXa2BdiET4jtPl0w3FrC971a2Mz+nrE+jVP+vkBBV7lZWSWptyX3Lj0VIz7YtbLDPF7jvmCUyF8Lf6qyAa1dzM8T8YPvtMg8GHvvDPCEyBPkqRvRfxwl4BnKbXJyXmvYWEjLpyI0qpq1iCxJu1BqFt1b/WDugQX3y3AXS+/3W41IBDwAMiDkkwhlnxoaQawlb0ZC5TFB1TA6pjLYBZ9zuljFX5XfhMDFSgK0/FBAcTzPQ/ICk26j460/RKiQhbiMYErDqJ+TZ5FUasg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780642809; c=relaxed/relaxed; bh=mLaeht+14OltYjlKRnSLpPtYOk2E9Ea1Lx7tk/hcws8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kA6qUinZSz7FSqUpCU+QOYEO25cTCwvuWWTvSymLsHpsw5NwmoUJYyhiwzdnams18b1/QNyXFr+BO/oPfqJ/xxPAj8dUp74sQovOAR48iZaCZ2lUHI5tZ8SraVv8Su27OMVsfXlGF6FuY9QMy3R8X+1pEkweTHC+kbhHS2GDZcF0+O+P6vlOrtYIjDa2uJh8nwz/FGcmr6ciYvHnoGDd68UFsZyUFhdrO+/wNBVo0oXb9iQDag9UYCOnnoQRoWec4LboLdpVkoHqHPI22aIHU48OEVhKrnZQIaG55FkQLniobbGX+ghJjfoRl+L6cRJtCrYDEF1pOHQW6YrYqB8afA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YsZyfuH0; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=peter.chen@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YsZyfuH0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=peter.chen@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gWskw6GMPz2xMW for ; Fri, 05 Jun 2026 17:00:08 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2195743A71; Fri, 5 Jun 2026 07:00:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF3B51F00893; Fri, 5 Jun 2026 06:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780642807; bh=mLaeht+14OltYjlKRnSLpPtYOk2E9Ea1Lx7tk/hcws8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YsZyfuH0DNQ7mv7u3TjtJz2xyIwZsrK8oVaqlPhk64DT+j0rV42P72G1+i/iwKkjR NRcuOWYnbQoyKyo3l2FM69tbt1G6e/HuNgC0tjlGYq95rMPDSYtqVOPYzvnqYUPxmO AWjPhYcJZ6wydfSYXF/XBNDK3f5d8IIgdI55O1W1HwIefukk8kexEUl8N5fsDeXx2z 4BExZj5mf+2VTADoOZFYWQlBUHvbteLd4O8xGa6QVu9YQUtYookUrNQ3mqvO9CAt4H 08LnpIh0I2Rne5hZA1mQuw5b6DWAlajftwY4jPb1w8G4b6cEGfnkYFO9vhRvcAILg8 LyUNuKdCiw8wA== Date: Fri, 5 Jun 2026 14:59:53 +0800 From: "Peter Chen (CIX)" To: Bartosz Golaszewski Cc: Andy Shevchenko , Lee Jones , Mark Brown , Thierry Reding , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Saravana Kannan , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Andi Shyti , Joerg Roedel , Will Deacon , Robin Murphy , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Ulf Hansson , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Matthew Brost , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi , David Airlie , Simona Vetter , Paul Cercueil , Bin Liu , Philipp Zabel , Maximilian Luz , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Krzysztof Kozlowski , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org, iommu@lists.linux.dev, linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-mips@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 20/23] usb: chipidea: use platform_device_set_of_node_from_dev() Message-ID: References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> <20260521-pdev-fwnode-ref-v1-20-88c324a1b8d2@oss.qualcomm.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 26-06-04 08:34:16, Bartosz Golaszewski wrote: > On Tue, 2 Jun 2026 23:49:29 +0200, Andy Shevchenko > said: > > On Thu, May 21, 2026 at 10:36:43AM +0200, Bartosz Golaszewski wrote: > >> Ahead of reworking the reference counting logic for platform devices, > >> encapsulate the assignment of the OF node from another device for > >> dynamically allocated platform devices with the provided helper. > > > > ... > > > >> pdev->dev.parent = dev; > >> - device_set_of_node_from_dev(&pdev->dev, dev); > >> + platform_device_set_of_node_from_dev(pdev, dev); > > > > Why do they even do that? Do they have a USB connected pin control? > > > > I don't know. I can't test it so I don't want to break it. If they don't need > it, the person who can test it, can remove it later. > It was introduced by below commits: commit 0f153a1b8193ce768be4df0400aeb2c8f2a3b3da Author: Rob Herring Date: Wed Dec 15 16:56:46 2021 -0600 usb: chipidea: Set the DT node on the child device The ChipIdea glue drivers just copy the glue resources to the "ci_hdrc" child device. Instead, set the child device's DT node pointer to the parent device's node so that platform_get_irq() can find the IRQ resources in the DT. This removes the need for statically populating the IRQ resources from the DT which has been deprecated for some time. Acked-by: Peter Chen Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20211215225646.1997946-1-robh@kernel.org Signed-off-by: Greg Kroah-Hartman -- Best regards, Peter