From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Scott Branden" <scott.branden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Keng-Yu Lin" <keng-yu.lin@hpe.com>,
"Vaibhaav Ram T.L" <vaibhaavram.tl@microchip.com>,
"Kumaravel Thiagarajan" <kumaravel.thiagarajan@microchip.com>,
"Alexander Usyskin" <alexander.usyskin@intel.com>,
"Vamsi Attunuru" <vattunuru@marvell.com>,
"Alexander Graf" <graf@amazon.com>,
"The AWS Nitro Enclaves Team"
<aws-nitro-enclaves-devel@amazon.com>,
"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
"Andrew Donnellan" <andrew+kernel@donnellan.id.au>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Frank Li" <Frank.Li@kernel.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andrea della Porta" <andrea.porta@suse.com>,
"Bryan Tan" <bryan-bt.tan@broadcom.com>,
"Vishnu Dasa" <vishnu.dasa@broadcom.com>,
"Naveen Krishna Chatradhi" <naveenkrishna.chatradhi@amd.com>,
"Akshay Gupta" <Akshay.Gupta@amd.com>,
"Kees Cook" <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 12/12] misc: Unify code style for various *_device_id arrays
Date: Mon, 20 Jul 2026 14:21:29 +0200 [thread overview]
Message-ID: <al4SyY2G8eD5O9Ms@qmqm.qmqm.pl> (raw)
In-Reply-To: <583653bc7b9ae19707bc28be69a20e66b8c3720a.1784299069.git.u.kleine-koenig@baylibre.com>
On Fri, Jul 17, 2026 at 04:50:58PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> - Add a trailing comma for initializers unless the closing brace is on
> the same line and for the list terminator;
> - Use a single space in the list terminator;
> - A space after an opening { and before a closing };
> - Use the PCI_DEVICE* macro in two drivers for pci_device_id entry
> which is usual for these arrays
> - No explicit zeros in the list terminator;
>
> None of these changes introduces changes to the compiled result.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
...
> drivers/misc/cb710/core.c | 5 +-
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
prev parent reply other threads:[~2026-07-20 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 14:50 [PATCH v2 00/12] misc: Improvements around *_device_id defintions Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 12/12] misc: Unify code style for various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-20 12:21 ` Michał Mirosław [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4SyY2G8eD5O9Ms@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=Akshay.Gupta@amd.com \
--cc=Frank.Li@kernel.org \
--cc=alexander.usyskin@intel.com \
--cc=andrea.porta@suse.com \
--cc=andrew+kernel@donnellan.id.au \
--cc=arnd@arndb.de \
--cc=aws-nitro-enclaves-devel@amazon.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bryan-bt.tan@broadcom.com \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=keng-yu.lin@hpe.com \
--cc=kishon@kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=kwilczynski@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mani@kernel.org \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=scott.branden@broadcom.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vaibhaavram.tl@microchip.com \
--cc=vattunuru@marvell.com \
--cc=vishnu.dasa@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox