From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hrndva-omtalb.mail.rr.com (hrndva-omtalb.mail.rr.com [71.74.56.124]) by ozlabs.org (Postfix) with ESMTP id 6B257DE8D3 for ; Thu, 21 Aug 2008 07:44:44 +1000 (EST) Date: Wed, 20 Aug 2008 17:44:41 -0400 (EDT) From: Steven Rostedt To: Benjamin Herrenschmidt Subject: Re: ftrace introduces instability into kernel 2.6.27(-rc2,-rc3) In-Reply-To: <1219268189.21386.65.camel@pasglop> Message-ID: References: <48591941.4070408@extricom.com> <48A92E15.2080709@extricom.com> <48A9901B.1080900@redhat.com> <20080818154746.GA26835@Krystal> <48A9AFA7.8080508@freescale.com> <1219110814.8062.2.camel@pasglop> <1219113549.8062.13.camel@pasglop> <1219114600.8062.15.camel@pasglop> <1219119431.8062.35.camel@pasglop> <1219216705.21386.46.camel@pasglop> <1219268189.21386.65.camel@pasglop> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Eran Liberty , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Steven Rostedt , Alan Modra , Scott Wood , "Paul E. McKenney" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 21 Aug 2008, Benjamin Herrenschmidt wrote: > > > > As you can see, it restores r1 -before- it pops r24..r31 off > > > the stack ! I let you imagine what happens if an interrupt happens > > > just in between those two instructions (mr and lmw). We don't do > > > redzones on our ABI, so basically, the registers end up corrupted > > > by the interrupt. > > > > Ouch! You've disassembled this without -pg too, and it does not have this > > bug? What version of gcc do you have? > > Oops, should have mentioned it ;-) > > 4.2.3 (Ubuntu 4.2.3-2ubuntu7) I'm running a 4.3.1 (Debian 4.3.1-2) on my powerbook. Perhaps the issue is already taken care of. -- Steve