Re: [PATCH] slub: Don't throw away partial remote slabs if there is no local memory

Nishanth Aravamudan
2014-01-24T22:20:08Z

On 24.01.2014 [13:03:13 -0800], David Rientjes wrote:
> On Fri, 24 Jan 2014, Christoph Lameter wrote:
>
> > On Fri, 24 Jan 2014, Wanpeng Li wrote:
> >
> > > >
> > > >diff --git a/mm/slub.c b/mm/slub.c
> > > >index 545a170..a1c6040 100644
> > > >--- a/mm/slub.c
> > > >+++ b/mm/slub.c
> > > >@@ -1700,6 +1700,9 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node,
> > > > void *object;
> > > > int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node;
> >
> > This needs to be numa_mem_id() and numa_mem_id would need to be
> > consistently used.
> >
> > > >
> > > >+ if (!node_present_pages(searchnode))
> > > >+ searchnode = numa_mem_id();
> >
> > Probably wont need that?
> >
>
> I think the problem is a memoryless node being used for kmalloc_node() so
> we need to decide where to enforce node_present_pages(). __slab_alloc()
> seems like the best candidate when !node_match().
>

Yep, I'm looking through callers and such right now and came to a
similar conclusion. I should have a patch soon.

Thanks,
Nish