From: Thomas Gleixner <tglx@linutronix.de>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: aik@ozlabs.ru, linux-kernel@vger.kernel.org, anton@samba.org,
shreyas@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug
Date: Tue, 20 Jan 2015 11:00:38 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1501201049371.5526@nanos> (raw)
In-Reply-To: <20150120081121.26984.46720.stgit@preeti.in.ibm.com>
On Tue, 20 Jan 2015, Preeti U Murthy wrote:
> --- a/kernel/time/tick-broadcast.c
> +++ b/kernel/time/tick-broadcast.c
> @@ -675,8 +675,8 @@ static void broadcast_move_bc(int deadcpu)
>
> if (!bc || !broadcast_needs_cpu(bc, deadcpu))
> return;
> - /* This moves the broadcast assignment to this cpu */
> - clockevents_program_event(bc, bc->next_event, 1);
> + /* This allows fresh nomination of broadcast cpu */
This comment should explain WHY this enforces the move of the
broadcast to a different cpu. 'Allows' is rather ambiguous.
> + bc->next_event.tv64 = KTIME_MAX;
Thanks,
tglx
prev parent reply other threads:[~2015-01-20 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 8:12 [PATCH V2] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug Preeti U Murthy
2015-01-20 10:00 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1501201049371.5526@nanos \
--to=tglx@linutronix.de \
--cc=aik@ozlabs.ru \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox