From: Julia Lawall <julia.lawall@lip6.fr>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Bhumika Goyal <bhumirks@gmail.com>,
benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: make irq_chip const, __initdata and __initconst
Date: Wed, 20 Sep 2017 08:34:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709200833320.4638@hadrien> (raw)
In-Reply-To: <87o9q5lwgq.fsf@concordia.ellerman.id.au>
On Wed, 20 Sep 2017, Michael Ellerman wrote:
> Bhumika Goyal <bhumirks@gmail.com> writes:
>
> > Make ehv_pic_irq_chip, mpic_ipi_chip and mpic_tm_chip const as they are
> > used only as a copy operation. This usage is during init, so make them
> > __initconst too.
> > Make mpic_ipi_chip __initdata as it is only modified during the init
> > phase and there is no reference of it anywhere after init.
>
> The change log doesn't seem to match the code.
>
> It's mpic_tm_chip which you marked __initdata, and that looks wrong, as
> we keep a pointer to it here:
>
> mpic->hc_tm = mpic_tm_chip;
This looks like a memory copy.
julia
next prev parent reply other threads:[~2017-09-20 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 14:12 [PATCH] powerpc: make irq_chip const, __initdata and __initconst Bhumika Goyal
2017-09-20 6:23 ` Michael Ellerman
2017-09-20 6:34 ` Julia Lawall [this message]
2017-09-20 11:11 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709200833320.4638@hadrien \
--to=julia.lawall@lip6.fr \
--cc=benh@kernel.crashing.org \
--cc=bhumirks@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox