From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yDCMP55r8zDqlv for ; Sat, 14 Oct 2017 03:09:01 +1100 (AEDT) Date: Fri, 13 Oct 2017 18:08:53 +0200 (CEST) From: Julia Lawall To: Bhumika Goyal cc: ruscur@russell.cc, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/eeh: make eeh_ops structures _ro_after_init In-Reply-To: <1507899850-22296-1-git-send-email-bhumirks@gmail.com> Message-ID: References: <1507899850-22296-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 13 Oct 2017, Bhumika Goyal wrote: > These structures are passed to the eeh_ops_register function during the > initialization phase. There they get stored in a structure variable > which only makes function calls through function pointers. There is no > other usage of these eeh_ops structures and their fields are never > modified after init phase. So, make them __ro_after_init. I think they could be const. julia > Signed-off-by: Bhumika Goyal > --- > arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +- > arch/powerpc/platforms/pseries/eeh_pseries.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c > index 4650fb2..d2a53df 100644 > --- a/arch/powerpc/platforms/powernv/eeh-powernv.c > +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c > @@ -1731,7 +1731,7 @@ static int pnv_eeh_restore_config(struct pci_dn *pdn) > return 0; > } > > -static struct eeh_ops pnv_eeh_ops = { > +static struct eeh_ops pnv_eeh_ops __ro_after_init = { > .name = "powernv", > .init = pnv_eeh_init, > .probe = pnv_eeh_probe, > diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c > index 6b812ad..6fedfc9 100644 > --- a/arch/powerpc/platforms/pseries/eeh_pseries.c > +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c > @@ -684,7 +684,7 @@ static int pseries_eeh_write_config(struct pci_dn *pdn, int where, int size, u32 > return rtas_write_config(pdn, where, size, val); > } > > -static struct eeh_ops pseries_eeh_ops = { > +static struct eeh_ops pseries_eeh_ops __ro_after_init = { > .name = "pseries", > .init = pseries_eeh_init, > .probe = pseries_eeh_probe, > -- > 1.9.1 > >