From: Satyam Sharma <satyam@infradead.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath
Date: Tue, 18 Sep 2007 05:38:57 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.0.999.0709180535470.8863@enigma.security.iitk.ac.in> (raw)
In-Reply-To: <alpine.LFD.0.999.0709180511070.8863@enigma.security.iitk.ac.in>
On Tue, 18 Sep 2007, Satyam Sharma wrote:
>
> > ------------[ cut here ]------------
> > Badness at arch/powerpc/kernel/smp.c:202
>
> comes when smp_call_function_map() has been called with irqs disabled,
> which is illegal. However, there is a special case, the panic() codepath,
> when we do not want to warn about this -- warning at that time is pointless
> anyway, and only serves to scroll away the *real* cause of the panic and
> distracts from the real bug.
BTW arch/ppc/ has same issue, but that's gonna be removed by next year
anyways, so I think there's no point making a patch for that (?)
next prev parent reply other threads:[~2007-09-18 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 10:05 [BUG][2.6.23-rc6] Badness at arch/powerpc/kernel/smp.c:202 Kamalesh Babulal
2007-09-14 10:37 ` Satyam Sharma
2007-09-14 11:03 ` Andy Whitcroft
2007-09-17 23:43 ` [PATCH] powerpc: Avoid pointless WARN_ON(irqs_disabled()) from panic codepath Satyam Sharma
2007-09-18 0:08 ` Satyam Sharma [this message]
2007-09-18 1:37 ` Randy Dunlap
2007-09-18 1:46 ` Josh Boyer
2007-09-19 13:45 ` Satyam Sharma
2007-09-19 15:29 ` Randy Dunlap
2007-09-20 8:25 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.999.0709180535470.8863@enigma.security.iitk.ac.in \
--to=satyam@infradead.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).