From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.linux-foundation.org (smtp2.linux-foundation.org [207.189.120.14]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.linux-foundation.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 23430DDE0C for ; Fri, 8 Feb 2008 09:54:25 +1100 (EST) Date: Thu, 7 Feb 2008 14:53:56 -0800 (PST) From: Linus Torvalds To: Paul Mackerras Subject: Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc In-Reply-To: <18347.34100.60973.215093@cargo.ozlabs.ibm.com> Message-ID: References: <18347.34100.60973.215093@cargo.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 8 Feb 2008, Paul Mackerras wrote: > > From: Tony Breeds > > Commit ad7f71674ad7c3c4467e48f6ab9e85516dae2720 corrected the clock > .. Please, when mentioning hex numbers, also do the one-liner shortlog. I realize that in gitk (or even just with two terminal windows open and a git repository) it's trivial to just follow the link and see what that commit was, but even you're just doing a "git log" or more commonly if you read the commit log somewhere else (like a mail gateway that posts them automatically when I apply things), it's really much more readable if you were to say something like: Commit ad7f71674ad7c3c4467e48f6ab9e85516dae2720 ("[POWERPC] Use a sensible default for clock_getres() in the VDSO") corrected the clock ... which reads much mroe naturally without having to go wonder what that commit was doing. No? As it is, I'm pretty used to editing those things in (I do it all the time), and I will do so for this email too, but I want to keep bringing this up so that I hopfully wouldn't have to do it so often. So please write your commit messages with the specific git information available, but without _requiring_ people to be git users to get the gist of the matter, ok? Linus