From: Linus Torvalds <torvalds@linux-foundation.org>
To: Paul Mackerras <paulus@samba.org>
Cc: boutcher@us.ibm.com, linuxppc-dev@ozlabs.org,
torvalds@linuxfoundation.org, devilbis@us.ibm.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH]: Remove bogons from the iSeries console
Date: Wed, 6 Aug 2008 17:44:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0808061742220.3462@nehalem.linux-foundation.org> (raw)
In-Reply-To: <18586.14112.751080.325656@cargo.ozlabs.ibm.com>
On Thu, 7 Aug 2008, Paul Mackerras wrote:
>
> I think you want "return -ENOIOCTLCMD" rather than "return ret" since
> ret is uninitialized with your patch applied.
Actually, nobody has apparently ever even tried compiling that function
even before.
Yes, 'ret' became uninitialized, but since it was never declared, it
doesn't matter - it wouldn't compile anyway.
> I agree the call to n_tty_ioctl is bogus but I think we just want to
> return -ENOIOCTLCMD.
I made that change, and in the spirit of that file I also didn't even try
to compile it. So if the end result sexually assaults your pets, don't
blame me.
Linus
prev parent reply other threads:[~2008-08-07 0:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 13:06 [PATCH]: Remove bogons from the iSeries console Alan Cox
2008-08-06 14:10 ` Stephen Rothwell
2008-08-06 16:57 ` Adrian Bunk
2008-08-06 23:43 ` Paul Mackerras
2008-08-06 23:35 ` Alan Cox
2008-08-07 0:44 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0808061742220.3462@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=boutcher@us.ibm.com \
--cc=devilbis@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).