From: Thomas Gleixner <tglx@linutronix.de>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
linuxppc-dev@ozlabs.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH resend4 2/3] itimers: fix periodic tics precision
Date: Mon, 25 May 2009 14:32:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0905251423490.3582@localhost.localdomain> (raw)
In-Reply-To: <20090525132814.442877e5@dhcp-lab-109.englab.brq.redhat.com>
On Mon, 25 May 2009, Stanislaw Gruszka wrote:
> @@ -904,6 +905,7 @@ void __init time_init(void)
> tb_ticks_per_usec = ppc_tb_freq / 1000000;
> tb_to_us = mulhwu_scale_factor(ppc_tb_freq, 1000000);
> calc_cputime_factors();
> + cputime_one = jiffies_to_cputime(1);
1) The variable name is misleading.
2) The patch breaks all powerpc platforms which have
CONFIG_VIRT_CPU_ACCOUNTING=n and ia64 with
CONFIG_VIRT_CPU_ACCOUNTING=y
Thanks,
tglx
next prev parent reply other threads:[~2009-05-25 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090522154339.06d30f0a@dhcp-lab-109.englab.brq.redhat.com>
[not found] ` <alpine.LFD.2.00.0905221611380.3570@localhost.localdomain>
2009-05-25 11:28 ` [PATCH resend4 2/3] itimers: fix periodic tics precision Stanislaw Gruszka
2009-05-25 12:32 ` Thomas Gleixner [this message]
2009-05-25 12:51 ` Stanislaw Gruszka
2009-05-26 6:44 ` Stanislaw Gruszka
2009-05-26 12:04 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0905251423490.3582@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).