From: Thomas Gleixner <tglx@linutronix.de>
To: Guillaume Knispel <gknispel@proformatique.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Russell King <linux@arm.linux.org.uk>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Michael Buesch <mb@bu3sch.de>, Ingo Molnar <mingo@elte.hu>,
Linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] genirq: reliably replay pending edge-triggered irq
Date: Tue, 27 Apr 2010 15:42:11 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1004271537130.2951@localhost.localdomain> (raw)
In-Reply-To: <1271941798-9659-2-git-send-email-gknispel@proformatique.com>
On Thu, 22 Apr 2010, Guillaume Knispel wrote:
> When the critical section in handle_edge_irq() is executed after
> IRQ_DISABLED has been set in the one in disable_irq(), the interrupt is
in the one ? -ENOPARSE
> acked and masked at controller level and IRQ_PENDING is set.
> ---
> arch/arm/Kconfig | 4 ----
> arch/arm/configs/acs5k_defconfig | 1 -
> arch/arm/configs/acs5k_tiny_defconfig | 1 -
Changing the defconfigs should be a separate patch and I'm not
going to push such a thing through the genirq tree. The stale
entries do not hurt.
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 127b871..9bec343 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1423,7 +1423,7 @@ int setup_ioapic_entry(int apic_id, int irq,
> entry->polarity = polarity;
>
> /* Mask level triggered irqs.
> - * Use IRQ_DELAYED_DISABLE for edge triggered irqs.
> + * Edge triggered irqs can be resent by software.
That change is unrelated and should be done in a seperate patch.
Thanks,
tglx
next prev parent reply other threads:[~2010-04-27 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 13:09 [PATCH 0/2] genirq: reliably replay pending edge-triggered irq (plus doc) Guillaume Knispel
2010-04-22 13:09 ` [PATCH 1/2] genirq: reliably replay pending edge-triggered irq Guillaume Knispel
2010-04-27 13:42 ` Thomas Gleixner [this message]
2010-04-28 21:56 ` Guillaume Knispel
2010-04-28 22:28 ` Thomas Gleixner
2010-04-22 13:09 ` [PATCH 2/2] genirq: update doc Guillaume Knispel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1004271537130.2951@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=Linuxppc-dev@lists.ozlabs.org \
--cc=bzolnier@gmail.com \
--cc=gknispel@proformatique.com \
--cc=hskinnemoen@atmel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mb@bu3sch.de \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox