From: Thomas Gleixner <tglx@linutronix.de>
To: Esben Haabendal <eha@doredevelopment.dk>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 2/2] gpio: pca953x: add powerpc irq support
Date: Mon, 7 Jun 2010 01:39:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1006070129530.2933@localhost.localdomain> (raw)
In-Reply-To: <1275686731.2970.14.camel@eha.doredevelopment.dk>
On Fri, 4 Jun 2010, Esben Haabendal wrote:
NAK for various reasons (no particular order):
1) That patch misses a sensible changelog. See Documentation/Submit*
2) patch contains several independent changes, which need to be separated
> @@ -120,6 +124,10 @@ static int pca953x_gpio_direction_input(struct gpio_chip *gc, unsigned off)
> chip = container_of(gc, struct pca953x_chip, gpio_chip);
>
> reg_val = chip->reg_direction | (1u << off);
> +
> + if (reg_val == chip->reg_direction)
> + return 0;
> +
This is an optimization of its own value.
3) it breaks the driver. See http://lkml.org/lkml/2010/6/6/177 for a
detailed explanation
4) the virq/powerpc churn is horrible and I bet there are sane ways to
solve this, but it leave this to the powerpc experts.
Thanks,
tglx
next prev parent reply other threads:[~2010-06-06 23:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1275686504.git.eha@doredevelopment.dk>
2010-06-04 21:25 ` [PATCH 1/2] powerpc: ipic: use set_irq_chip to ensure irq_chip defaults are applied Esben Haabendal
2010-06-06 23:45 ` Thomas Gleixner
2010-06-07 5:06 ` Esben Haabendal
2010-06-07 10:22 ` Thomas Gleixner
2010-06-07 11:41 ` Benjamin Herrenschmidt
2010-06-04 21:25 ` [PATCH 2/2] gpio: pca953x: add powerpc irq support Esben Haabendal
2010-06-06 23:39 ` Thomas Gleixner [this message]
2010-06-07 5:50 ` Esben Haabendal
2010-06-07 10:30 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006070129530.2933@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=eha@doredevelopment.dk \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).