From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relais.videotron.ca (relais.videotron.ca [24.201.245.36]) by ozlabs.org (Postfix) with ESMTP id 7D0B3B6EF1 for ; Sat, 17 Jul 2010 06:29:51 +1000 (EST) MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_cf5cJET10pUohhLdmpzuSA)" Received: from xanadu.home ([66.130.28.92]) by VL-MR-MR001.ip.videotron.ca (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTP id <0L5O00EQJ3LP9SA0@VL-MR-MR001.ip.videotron.ca> for linuxppc-dev@lists.ozlabs.org; Fri, 16 Jul 2010 16:29:50 -0400 (EDT) Date: Fri, 16 Jul 2010 16:29:49 -0400 (EDT) From: Nicolas Pitre To: Grant Likely Subject: Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig In-reply-to: Message-id: References: <20100713230352.6781.18644.stgit@angua> <1279296221.17878.66.camel@e102109-lin.cambridge.arm.com> <20100716183028.GB26854@n2100.arm.linux.org.uk> <1279310976.18579.8.camel@e102109-lin.cambridge.arm.com> Cc: Stephen Rothwell , Daniel Walker , Russell King - ARM Linux , linux-kbuild@vger.kernel.org, Tony Lindgren , Catalin Marinas , linuxppc-dev@lists.ozlabs.org, lkml , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Linus Torvalds , linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --Boundary_(ID_cf5cJET10pUohhLdmpzuSA) Content-type: TEXT/PLAIN; charset=ISO-8859-1 Content-transfer-encoding: 8BIT On Fri, 16 Jul 2010, Grant Likely wrote: > On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas > wrote: > > On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: > >> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: > >> > > >> > DOH. > >> > >> Well, it's possible that the correct approach is a mixture. > >> > >> Automatically do the trivial cases (recursive selects, dependencies > >> that are simple or of the form "x && y" etc), and warn about the cases > >> that aren't trivial (where "not trivial" may not necessarily be about > >> fundamentally ambiguous ones, but just "complex enough that I won't > >> even try"). > > > > There is still a risk with this approach when the Kconfig isn't entirely > > correct. For example, on ARM we have (I pushed a patch already): > > > > config CPU_32v6K > >        depends on CPU_V6 > > > > config CPU_V7 > >        select CPU_32v6K > > > > In this simple approach, we end up selecting CPU_V6 when we only need > > CPU_V7. There other places like this in the kernel. > > > > Of course, kbuild could still warn but if people rely on this feature to > > select options automatically I suspect they would ignore the warnings. > > In my first patch, I made Kconfig problems errors instead of warnings. > That would prevent people from ignoring them. ACK. Nicolas --Boundary_(ID_cf5cJET10pUohhLdmpzuSA)--