From: Sebastian Ott <sebott@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Bjorn Helgaas <helgaas@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement
Date: Mon, 17 Dec 2018 18:30:18 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.21.1812171806330.28490@schleppi> (raw)
In-Reply-To: <20181214131802.GA13950@infradead.org>
On Fri, 14 Dec 2018, Christoph Hellwig wrote:
> On Fri, Dec 14, 2018 at 05:12:45AM -0800, Christoph Hellwig wrote:
> > On Thu, Dec 13, 2018 at 06:54:28PM +0100, Sebastian Ott wrote:
> > > Implement pcibios_sriov_{add|del}_vfs as empty functions. VF
> > > creation will be triggered by the hotplug code.
> >
> > And instead of having the arch suplply a no-op arch override I
> > think it would be better to have the config option just stub it
> > out in common code.
>
> Or in fact maybe even a runtime flag in struct pci_dev. Who knows
> if all future s390 PCIe busses will have exactly the same behavior
> or if we eventually get the standards compliant behvior back?
Something like this:
https://lore.kernel.org/linux-pci/20181212215453.GJ99796@google.com/T/#m649d86ea3c65f669c74d048f89afbaf473876ac3
Not a runtime flag, but a function pointer in struct pci_host_bridge.
This would provide the requested flexibility. The problem with this
approach is that it requires other patches that are not yet upstream
(https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=pci-probe-rework).
Since this discussion is going on since a few months and I want to
have this code upstream and in distributions for HW enablement I've
asked Bjorn to go with the initial approach (weak functions) and
promised to move that to struct pci_host_bridge once Arnd's patches
are upstream. Would that be OK for you too?
Regards,
Sebastian
next prev parent reply other threads:[~2018-12-17 17:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180912123411.23229-1-sebott@linux.ibm.com>
2018-09-12 13:02 ` [PATCH 0/2] sriov enablement on s390 Bjorn Helgaas
2018-09-12 14:40 ` Benjamin Herrenschmidt
2018-09-13 12:41 ` Sebastian Ott
2018-09-13 12:41 ` [PATCH 1/2] pci: provide add_vfs/del_vfs callbacks Sebastian Ott
2018-09-13 12:41 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-10-10 12:55 ` [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-10-10 16:26 ` Bjorn Helgaas
2018-12-05 13:45 ` Sebastian Ott
2018-12-12 21:54 ` Bjorn Helgaas
2018-12-13 17:54 ` [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-13 17:54 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:18 ` Christoph Hellwig
2018-12-17 17:30 ` Sebastian Ott [this message]
2018-12-17 17:35 ` Christoph Hellwig
2018-12-18 10:16 ` [PATCH 1/2] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
2018-12-20 20:07 ` Bjorn Helgaas
2018-12-21 14:14 ` [PATCH 1/3] PCI/IOV: factor out sriov_add_vfs Sebastian Ott
2018-12-21 14:14 ` [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-21 14:14 ` [PATCH 3/3] s390/pci: " Sebastian Ott
2018-12-21 14:19 ` [PATCH 1/2] PCI/IOV: provide flag to " Sebastian Ott
2019-01-02 1:14 ` Bjorn Helgaas
2018-12-18 10:16 ` [PATCH 2/2] s390/pci: " Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1812171806330.28490@schleppi \
--to=sebott@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox