From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B7BC43219 for ; Wed, 1 May 2019 02:31:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BF022087B for ; Wed, 1 May 2019 02:31:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BF022087B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-mips.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44v2Sh6VSvzDqSf for ; Wed, 1 May 2019 12:31:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux-mips.org (client-ip=148.251.95.138; helo=cvs.linux-mips.org; envelope-from=macro@linux-mips.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-mips.org Received: from cvs.linux-mips.org (eddie.linux-mips.org [148.251.95.138]) by lists.ozlabs.org (Postfix) with ESMTP id 44v2R81fgyzDqSL for ; Wed, 1 May 2019 12:29:39 +1000 (AEST) Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S23990394AbfEAC3gOuPKs (ORCPT ); Wed, 1 May 2019 04:29:36 +0200 Date: Wed, 1 May 2019 03:29:36 +0100 (BST) From: "Maciej W. Rozycki" To: "Enrico Weigelt, metux IT consult" Subject: Re: [PATCH 06/41] drivers: tty: serial: sb1250-duart: use dev_err() instead of printk() In-Reply-To: <1556369542-13247-7-git-send-email-info@metux.net> Message-ID: References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-7-git-send-email-info@metux.net> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-mips@vger.kernel.org, andrew@aj.id.au, Greg Kroah-Hartman , sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, sparclinux@vger.kernel.org, khilman@baylibre.com, linux-serial@vger.kernel.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 27 Apr 2019, Enrico Weigelt, metux IT consult wrote: > diff --git a/drivers/tty/serial/sb1250-duart.c b/drivers/tty/serial/sb1250-duart.c > index 329aced..655961c 100644 > --- a/drivers/tty/serial/sb1250-duart.c > +++ b/drivers/tty/serial/sb1250-duart.c > @@ -663,7 +663,6 @@ static void sbd_release_port(struct uart_port *uport) > > static int sbd_map_port(struct uart_port *uport) > { > - const char *err = KERN_ERR "sbd: Cannot map MMIO\n"; > struct sbd_port *sport = to_sport(uport); > struct sbd_duart *duart = sport->duart; > > @@ -671,7 +670,7 @@ static int sbd_map_port(struct uart_port *uport) > uport->membase = ioremap_nocache(uport->mapbase, > DUART_CHANREG_SPACING); > if (!uport->membase) { > - printk(err); > + dev_err(uport->dev, "Cannot map MMIO (base)\n"); > return -ENOMEM; > } > > @@ -679,7 +678,7 @@ static int sbd_map_port(struct uart_port *uport) > sport->memctrl = ioremap_nocache(duart->mapctrl, > DUART_CHANREG_SPACING); > if (!sport->memctrl) { > - printk(err); > + dev_err(uport->dev, "Cannot map MMIO (ctrl)\n"); > iounmap(uport->membase); > uport->membase = NULL; > return -ENOMEM; Hmm, what's the point to have separate messages, which consume extra memory, for a hardly if at all possible error condition? Maciej