From: fthain@telegraphics.com.au
To: Brad Boyer <flar@allandria.com>
Cc: Michael Beardsworth <mbeards2@uoregon.edu>,
linux-m68k@vger.kernel.org, benh@kernel.crashing.or,
Michael Beardsworth <mbeards@mbeards-mbp.lulzzzzzzz.info>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Macintosh: fix brace and trailing statement coding style issues in adb-iop.c This is a patch to the adb-iop.c file that cleans up brace and trailing statement warnings found by the checkpatch.pl tool. Signed-off-by: Michael Beardsworth <mbeards2@uoregon.edu>
Date: Sun, 21 Mar 2010 20:16:02 +1100 (EST) [thread overview]
Message-ID: <alpine.LNX.2.00.1003212013350.5911@nippy.intranet> (raw)
In-Reply-To: <20100320230801.GA5000@cynthia.pants.nu>
> On Tue, Mar 09, 2010 at 01:46:20PM -0800, Michael Beardsworth wrote:
> >...
> >
> > #ifdef DEBUG_ADB_IOP
> > - printk("adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X", req,
> > - (uint) amsg->count + 2, (uint) amsg->flags, (uint) amsg->cmd);
> > + printk(KERN_WARNING "adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X",
> > + req, (uint) amsg->count + 2, (uint) amsg->flags, (uint) amsg->cmd);
> > for (i = 0; i < amsg->count; i++)
> > printk(" %02X", (uint) amsg->data[i]);
> > printk("\n");
> >...
> > #ifdef DEBUG_ADB_IOP
> > - printk("adb_iop_start %p: sending packet, %d bytes:", req, req->nbytes);
> > + printk(KERN_WARNING "adb_iop_start %p: sending packet, %d bytes:", req, req->nbytes);
> > for (i = 0 ; i < req->nbytes ; i++)
> > printk(" %02X", (uint) req->data[i]);
> > printk("\n");
KERN_DEBUG is used for debugging messages, not KERN_WARNING.
Finn
prev parent reply other threads:[~2010-03-21 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 21:46 [PATCH] Macintosh: fix brace and trailing statement coding style issues in adb-iop.c This is a patch to the adb-iop.c file that cleans up brace and trailing statement warnings found by the checkpatch.pl tool. Signed-off-by: Michael Beardsworth <mbeards2@uoregon.edu> Michael Beardsworth
2010-03-20 23:08 ` Brad Boyer
2010-03-21 9:16 ` fthain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1003212013350.5911@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=benh@kernel.crashing.or \
--cc=flar@allandria.com \
--cc=linux-m68k@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mbeards2@uoregon.edu \
--cc=mbeards@mbeards-mbp.lulzzzzzzz.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox