From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Joshua Thompson <funaho@jurai.org>,
Mathieu Malaterre <malat@debian.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Ungerer <gerg@linux-m68k.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Meelis Roos <mroos@linux.ee>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling
Date: Sun, 8 Jul 2018 21:45:21 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1807082133130.49@nippy.intranet> (raw)
In-Reply-To: <CAMuHMdWzO1jzd=8SN5G_eoFObEAJR4-5u7JDExMefR__30QauA@mail.gmail.com>
On Sun, 8 Jul 2018, Geert Uytterhoeven wrote:
> On Fri, Jun 22, 2018 at 10:55 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > I don't think anyone so far had a strong preference here, so I went
> > with what Mathieu suggested and kept the original Mac behavior, but
> > added the WARN_ON().
>
> So, is this safe to apply?
> Especially in light of the warnings seen by Meelis with the PPC version.
>
You mean, "can we apply this and avoid warning splats?"
Meelis's result says, "no".
I forget what date the RTC gets set to when the PMU/Cuda is reset but I
suspect that timezone arithmetic in either MacOS or Linux could cause it
to end up in 1969.
So I'd prefer to see the WARN_ON() removed.
--
next prev parent reply other threads:[~2018-07-08 11:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 14:02 [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions Arnd Bergmann
2018-06-19 14:02 ` [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling Arnd Bergmann
2018-06-22 5:26 ` Finn Thain
2018-06-22 8:54 ` Arnd Bergmann
2018-07-08 10:49 ` Geert Uytterhoeven
2018-07-08 11:45 ` Finn Thain [this message]
2018-07-18 11:36 ` Geert Uytterhoeven
2018-07-18 12:02 ` Finn Thain
2018-07-18 12:20 ` Arnd Bergmann
2018-07-18 13:49 ` Finn Thain
2018-07-18 14:26 ` Arnd Bergmann
2018-07-22 11:56 ` Finn Thain
2018-07-23 8:08 ` Geert Uytterhoeven
2018-06-19 14:02 ` [PATCH 3/3] [v2] m68k: remove unused set_clock_mmss() helpers Arnd Bergmann
2018-07-18 11:37 ` Geert Uytterhoeven
2018-06-20 7:16 ` [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions Mathieu Malaterre
2018-07-01 15:47 ` Meelis Roos
2018-07-09 21:31 ` Arnd Bergmann
2018-07-10 1:18 ` Finn Thain
2018-06-27 4:32 ` Michael Ellerman
2018-06-27 10:36 ` Arnd Bergmann
2018-06-27 12:41 ` Michael Ellerman
2018-06-27 21:41 ` [1/3,v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1807082133130.49@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
--cc=mpe@ellerman.id.au \
--cc=mroos@linux.ee \
--cc=paulus@samba.org \
--cc=schwab@linux-m68k.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).