From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54489C433FE for ; Sat, 5 Dec 2020 03:13:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2857722B4E for ; Sat, 5 Dec 2020 03:13:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2857722B4E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=telegraphics.com.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Cnvm412c6zDqvZ for ; Sat, 5 Dec 2020 14:13:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=telegraphics.com.au (client-ip=98.124.60.144; helo=kvm5.telegraphics.com.au; envelope-from=fthain@telegraphics.com.au; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=telegraphics.com.au Received: from kvm5.telegraphics.com.au (kvm5.telegraphics.com.au [98.124.60.144]) by lists.ozlabs.org (Postfix) with ESMTP id 4CnvhV4wjwzDqwy for ; Sat, 5 Dec 2020 14:10:18 +1100 (AEDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 7137B2B617; Fri, 4 Dec 2020 22:10:15 -0500 (EST) Date: Sat, 5 Dec 2020 14:10:21 +1100 (AEDT) From: Finn Thain To: Geert Uytterhoeven Subject: Re: [PATCH] macintosh/adb-iop: Send correct poll command In-Reply-To: Message-ID: References: <58bba4310da4c29b068345a4b36af8a531397ff7.1605847196.git.fthain@telegraphics.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev , Linux Kernel Mailing List , Joshua Thompson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 4 Dec 2020, Geert Uytterhoeven wrote: > Hi Finn, > > On Fri, Nov 20, 2020 at 5:54 AM Finn Thain wrote: > > The behaviour of the IOP firmware is not well documented but we do know > > that IOP message reply data can be used to issue new ADB commands. > > Use the message reply to better control autopoll behaviour by sending > > a Talk Register 0 command after every ADB response, not unlike the > > algorithm in the via-macii driver. This poll command is addressed to > > that device which last received a Talk command (explicit or otherwise). > > > > Cc: Joshua Thompson > > Fixes: fa3b5a9929fc ("macintosh/adb-iop: Implement idle -> sending state transition") > > WARNING: Unknown commit id 'fa3b5a9929fc', maybe rebased or not pulled? > > 32226e817043? > Yes, that's the one. I accidentally gave a commit id from one of my backport branches. > > Tested-by: Stan Johnson > > Signed-off-by: Finn Thain > > Thanks, will queue in the m68k for-v5.11 branch. > Thanks. > Gr{oetje,eeting}s, > > Geert > >