From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.it.da.ut.ee (smtp1.it.da.ut.ee [IPv6:2001:bb8:2002:500::46]) by lists.ozlabs.org (Postfix) with ESMTP id 42HQfP2151zF3Nj for ; Sat, 22 Sep 2018 19:49:15 +1000 (AEST) Date: Sat, 22 Sep 2018 12:49:06 +0300 (EEST) From: Meelis Roos Sender: mroos@math.ut.ee To: Joel Stanley cc: Krzysztof Kozlowski , Greg Kroah-Hartman , Herbert Xu , Michael Ellerman , Christophe LEROY , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/xz: Put CRC32_POLY_LE in xz_private.h In-Reply-To: <20180921025431.28366-1-joel@jms.id.au> Message-ID: References: <20180921025431.28366-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > This fixes a regression introduced by faa16bc404d72a5 ("lib: Use > existing define with polynomial"). > > The cleanup added a dependency on include/linux, which broke the PowerPC > boot wrapper/decompresser when KERNEL_XZ is enabled: > > BOOTCC arch/powerpc/boot/decompress.o > In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:233, > from arch/powerpc/boot/decompress.c:42: > arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:10: fatal error: > linux/crc32poly.h: No such file or directory > #include > ^~~~~~~~~~~~~~~~~~~ > > The powerpc decompresser is a hairy corner of the kernel. Even while building > a 64-bit kernel it needs to build a 32-bit binary and therefore avoid including > files from include/linux. > > This allows users of the xz library to avoid including headers from > 'include/linux/' while still achieving the cleanup of the magic number. > > Fixes: faa16bc404d72a5 ("lib: Use existing define with polynomial") > Reported-by: Meelis Roos > Reported-by: kbuild test robot > Suggested-by: Christophe LEROY > Signed-off-by: Joel Stanley Tested-by: Meelis Roos -- Meelis Roos (mroos@linux.ee)