From: Hugh Dickins <hughd@google.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Hugh Dickins <hughd@google.com>, linuxppc-dev@lists.ozlabs.org
Subject: ppc64 4kB: MAX_PHYSMEM_BITS undefined
Date: Mon, 8 Apr 2019 13:23:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.11.1904081305030.1656@eggly.anvils> (raw)
Hi Ben,
5.1-rc's 8bc086899816 ("powerpc/mm: Only define MAX_PHYSMEM_BITS in
SPARSEMEM configurations") has sadly broken the build for my config
on the G5, which has (amongst a few other options):
CONFIG_PPC_BOOK3S_64=y
CONFIG_PPC_BOOK3S=y
CONFIG_ARCH_SPARSEMEM_ENABLE=y
CONFIG_ARCH_SPARSEMEM_DEFAULT=y
CONFIG_PPC_4K_PAGES=y
# CONFIG_PPC_64K_PAGES is not set
# CONFIG_SPARSEMEM_MANUAL is not set
CONFIG_SPARSEMEM_VMEMMAP_ENABLE=y
Easily enough worked around for me by...
--- 5.1-rc4/arch/powerpc/include/asm/mmu.h 2019-03-24 15:40:26.833378215 -0700
+++ linux/arch/powerpc/include/asm/mmu.h 2019-04-07 19:51:11.419295089 -0700
@@ -352,7 +352,7 @@ static inline bool strict_kernel_rwx_ena
#if defined(CONFIG_SPARSEMEM_VMEMMAP) && defined(CONFIG_SPARSEMEM_EXTREME) && \
defined (CONFIG_PPC_64K_PAGES)
#define MAX_PHYSMEM_BITS 51
-#elif defined(CONFIG_SPARSEMEM)
+#else
#define MAX_PHYSMEM_BITS 46
#endif
...but I don't suppose that's what you want to do.
I wonder if there was a momentary mixup between 64 bits and 64kB pages -
I'm a non-conformist using 4kB pages on ppc64.
Hugh
reply other threads:[~2019-04-08 20:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1904081305030.1656@eggly.anvils \
--to=hughd@google.com \
--cc=ben@decadent.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox