From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kees Cook <kees@kernel.org>
Cc: "Bill Wendling" <morbo@google.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Thorsten Blum" <blum@kernel.org>,
"Shivaprasad G Bhat" <sbhat@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
"Steven Rostedt" <rostedt@goodmis.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 6/7] powerpc/papr_scm: Return the string length from the sysfs show functions
Date: Thu, 17 Sep 2026 15:50:23 +0300 [thread overview]
Message-ID: <aqviD9ow5HLGcLTK@ashevche-desk.local> (raw)
In-Reply-To: <20260917002333.2306346-6-kees@kernel.org>
On Wed, Sep 16, 2026 at 05:23:18PM -0700, Kees Cook wrote:
> perf_stats_show() and flags_show() build their output with a seq_buf
> and return seq_buf_used(), which may include the trailing NUL byte
> when the seq_buf has overflowed. Use seq_buf_strlen() instead.
>
> Build tested ARCH=powerpc ppc64_defconfig with GCC powerpc64-linux-gnu
> 16.1.0:
> arch/powerpc/platforms/pseries/papr_scm.o
...
> free_stats:
> kfree(stats);
> - return rc ? rc : (ssize_t)seq_buf_used(&s);
> + return rc ? rc : (ssize_t)seq_buf_strlen(&s);
> }
On a brief look it's a single ternary like this in the file, perhaps while at
it move to Elvis op?
return rc ?: (ssize_t)seq_buf_strlen(&s);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-17 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260917002312.i.923-kees@kernel.org>
2026-09-17 0:23 ` [PATCH 6/7] powerpc/papr_scm: Return the string length from the sysfs show functions Kees Cook
2026-09-17 12:50 ` Andy Shevchenko [this message]
2026-09-17 21:19 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqviD9ow5HLGcLTK@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=blum@kernel.org \
--cc=chleroy@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=sbhat@linux.ibm.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox