From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3C74606A33A for ; Thu, 5 Nov 2026 21:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KFA+ZicK Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jLG5Z4XJ5z2yj1; Fri, 06 Nov 2026 08:43:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793915010; cv=none; b=oWIt2eb09CNelqgUqBPSqxUiaJ+R5pyYoCrNsLszzy8GhOMHDU+Tj2Rf7KNSAtB/wpPnacl/c1VYdWFnOX1WCoOLvjNAf1kf/FQ9ttJhK3ZPrfryGXF9+1oLnogj+9ZR3FueB0Sr1QA83Mj5Kp1y63brWJLP+mihmhCHJCYcU5O/eV4xEE4CJlmDyH/R/LPaz9uXDWfzhcsFHCW1nh1BXgSfzhDxKR3ijpkkb/h1up/Pfw2FRya1tCGt4n+77c7tqaDq1nQpIgapvRbYTONwNDSNFcncyfjVjFkUhqUpbsS1UT9saFVu2zJAd7aaj6BIs/ooKIi67PuKeY8kguJsTw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793915010; c=relaxed/relaxed; bh=nnsNMtUi8B/PfO4GG0OW4lr6jLs4u50NUe2xEiA6RC0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ffd5xgAgspoq2n+I2ZELgphrl90az4gTDIoxhwe58OFQhFb0nZTcC/h4OBN1n8vNNYGGpNYFmInr0esIqx1W8XmWv4riZTrzRvCxL/aOQMkDGCSiq9ZRPAqBc9OlH17KYNhG33w7YM9CLmYRfaNDpTIEfXdEy7ZFFyBZ3VcxQu4Xigd2WKwwv+zbS9T+Ikz8FLfYV571f1U7YfLDcpQ8l1rPwBwqxGLGqIlJNtODG/cSoRZjMCM5X2CkrkxpUeQMTavu79Z7YtfFCOIcqi00bc90vQLYOQSIQV6lcebF4YqNXE6+ivFlHjC5Se12B10SCJkGuSx7eXHML7eAyooyHg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KFA+ZicK; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KFA+ZicK; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with UTF8SMTPS id 4jLG5Y4gLzz2ygW; Fri, 06 Nov 2026 08:43:29 +1100 (AEDT) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with UTF8SMTP id AC45343451; Thu, 5 Nov 2026 21:43:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with UTF8SMTPSA id 0AE881F0089F; Thu, 5 Nov 2026 21:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793915007; bh=nnsNMtUi8B/PfO4GG0OW4lr6jLs4u50NUe2xEiA6RC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KFA+ZicKHpTxqbxZeNU9rKNH0zDIw+G9WkxRcTelADPJIyDG9z+SV38MG0CjPlcEC 1gjbq2m9ysrv8pBHAJrvqPnMERLZq6W4rxcogl2DlIDB44RylaSdblCTSEXNnxfcbK l3RbrI5Oxv1bkdw/nOHwLpMlw6rPe3TmPXrqXYMaHNImuFIqgFREHKoGTzOn5W2eUw HnogndejHth27NGEbdc3qPN/i0WWKweuYdEdmiZr5RDjCfk6/mEdy1F9Yu6XlveCU2 QfoEW83U8XIbYRbkOdJsXHQEOAAPFI6k6EpuBWa/BFfpmagRIXSu+HdiZvkzWIUa8b kW/HsHhM4i4og== Date: Thu, 5 Nov 2026 23:43:23 +0200 From: Jarkko Sakkinen To: "Lorenzo Stoakes (ARM)" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Madhavan Srinivasan , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jan Kara , Paul Moore , Stephen Smalley , Ondrej =?utf-8?B?TW9zbsOhxI1law==?= , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Jens Wiklander , Sumit Garg , Scott Branden , Broadcom internal kernel review list , Arnd Bergmann , Greg Kroah-Hartman , Richard Cochran , David Woodhouse , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-sgx@vger.kernel.org, selinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, netdev@vger.kernel.org Subject: Re: [PATCH 05/14] x86/sgx: convert vepc mmap hook to mmap_prepare Message-ID: References: <20261105-late-2026-mmap_prepare-v1-0-c56aadfbab8a@kernel.org> <20261105-late-2026-mmap_prepare-v1-5-c56aadfbab8a@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105-late-2026-mmap_prepare-v1-5-c56aadfbab8a@kernel.org> X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 05, 2026 at 09:05:36PM +0000, Lorenzo Stoakes (ARM) wrote: > Move from the deprecated mmap hook to the new mmap_prepare hook. The hook > only checks that the mapping is shared and sets VMA flags, operations and > private data. > > Signed-off-by: Lorenzo Stoakes (ARM) > --- > arch/x86/kernel/cpu/sgx/virt.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c > index 6a1933ddc6fc..850990519ca5 100644 > --- a/arch/x86/kernel/cpu/sgx/virt.c > +++ b/arch/x86/kernel/cpu/sgx/virt.c > @@ -98,17 +98,18 @@ static const struct vm_operations_struct sgx_vepc_vm_ops = { > .fault = sgx_vepc_fault, > }; > > -static int sgx_vepc_mmap(struct file *file, struct vm_area_struct *vma) > +static int sgx_vepc_mmap_prepare(struct vm_area_desc *desc) > { > - struct sgx_vepc *vepc = file->private_data; > + struct sgx_vepc *vepc = desc->file->private_data; > > - if (!(vma->vm_flags & VM_SHARED)) > + if (!vma_desc_test(desc, VMA_SHARED_BIT)) > return -EINVAL; > > - vma->vm_ops = &sgx_vepc_vm_ops; > + desc->vm_ops = &sgx_vepc_vm_ops; > /* Don't copy VMA in fork() */ > - vm_flags_set(vma, VM_PFNMAP | VM_IO | VM_DONTDUMP | VM_DONTCOPY); > - vma->vm_private_data = vepc; > + vma_desc_set_flags(desc, VMA_PFNMAP_BIT, VMA_IO_BIT, VMA_DONTDUMP_BIT, > + VMA_DONTCOPY_BIT); > + desc->private_data = vepc; > > return 0; > } > @@ -315,7 +316,7 @@ static const struct file_operations sgx_vepc_fops = { > .unlocked_ioctl = sgx_vepc_ioctl, > .compat_ioctl = sgx_vepc_ioctl, > .release = sgx_vepc_release, > - .mmap = sgx_vepc_mmap, > + .mmap_prepare = sgx_vepc_mmap_prepare, > }; > > static struct miscdevice sgx_vepc_dev = { > > -- > 2.56.0 > Reviewed-by: Jarkko Sakkinen Br, Jarkko