From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADED1606A327 for ; Sat, 14 Nov 2026 18:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g+siPjM4 Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jRk1q3FVMz3cBT; Sun, 15 Nov 2026 05:59:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794682751; cv=none; b=iwoTYsSWzBAaAD5rLOrNmdwt10+SJg38Qe3gLnXGp6N9GYNnXAYFHrQJPkH9IqYUZ60dxN0ElMaoObj1zYj85SDN028cW4nkdfsoxSfo7m2/rZmghLAnNaY8NokeEQVV33bdVG+momy7huT15144nbQsPiwEkPycuzUsrgOIGJ0unRHp47epWp6NT3I8I5ue2DrYYd3Slp265u2L979Sk9mg5U1IEp0ZXak248wEOkmSqgE7UyQosR6o6qZUr9lsRaQ9t4q7JRCnKctgvKsaJkL6dJAuMFRiYsqPaKe7VfezB1d+rVYnlVLmc7QlMnRulSwi7GbCEICwq1LZr9tWPQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1794682751; c=relaxed/relaxed; bh=9RzpuEYsnkvuLxM7zo3RdF3Gc3FUtoCDNsh2Uv68tmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jacsQO10brGCdVf2jHoqxnz2h/J3sIgPMeFFBDxalA/mF2XHzffxF+xv4uWLL7xhGJ3vRH9srJm1NWxLYg4WpEVs8pymVtrHOTOCgvTxzkEkKr82PB9fe+cSogq23doNNrKSebwdsc1Azi8fIdeIi+ARBmFNrXawl40sl2cFTZbHKgROt/PfeMseesPTJpjiGEBvKHLRe2oFVyBESd3fFmVXLtxQ34RXBnvVlNwfCoQ3WjAsorXsIZfrxC3FTeSCGVQlArsfkKm9zb7TRi3Ci7uhBTJjjEAFdYtEWaS62PaP3/7OkaMWchcqKlcoHUI0l3j+camWyGSEr6DMyC1xWw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g+siPjM4; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=g+siPjM4; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jRk1p68QJz3c9k for ; Sun, 15 Nov 2026 05:59:10 +1100 (AEDT) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id EEC7660E15; Sat, 14 Nov 2026 18:59:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54B311F000C4; Sat, 14 Nov 2026 18:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794682748; bh=9RzpuEYsnkvuLxM7zo3RdF3Gc3FUtoCDNsh2Uv68tmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=g+siPjM4yAFSviPGPS/cwHbu8OZzs8PoMVBZNdEnXQLMBPyyPFkTXapgCKl/hjAae dCJNWlK/TEWojBDTpL/ghuz087T3k/gyiU1eB4mNldla+3S52rlDtKLQugauMusEqP 6RRTxZxPcFw62PN+1KM6bBdAb6eh04dR903SHM9pa1o6uQw8B29gZKllO+p9VBvKP4 AykfttBIFa99OrjXCIgHJOPgJL1GKmxAXilXFDc6jR9GA0S/RI7teedpBYOyDfm618 MHfCc3/0hBDuNZP996VXFGHsvBIYJnGDN7X2XFBKb+zgXGpV+9xAoBHm8lRzgwoq1R tW/dULWGdjNCw== Date: Sat, 14 Nov 2026 18:58:59 +0000 From: "Lorenzo Stoakes (ARM)" To: "David Hildenbrand (Arm)" Cc: "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Willy Tarreau , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Chris Wilson , Matthew Auld , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Rik van Riel , Benjamin Herrenschmidt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 3/5] drm/i915/selftests: request read access for mmap access tests Message-ID: References: <20261112-access_shite-v1-0-988a5c470db2@kernel.org> <20261112-access_shite-v1-3-988a5c470db2@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261112-access_shite-v1-3-988a5c470db2@kernel.org> X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 12, 2026 at 11:08:59PM +0100, David Hildenbrand (Arm) wrote: > __igt_mmap_access() reads the buffer with access_process_vm() without > FOLL_FORCE, but creates the mapping with only PROT_WRITE. Request > PROT_READ as well so the test remains valid when we fix the ->access > fallback to properly check VMA access permissions. > > Fixes: 9f909e215fea ("drm/i915: Implement vm_ops->access for gdb access into mmaps") > Signed-off-by: David Hildenbrand (Arm) Seems sensible so: Acked-by: Lorenzo Stoakes (ARM) > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index 303be698891fd..d9c828032a1aa 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -1460,7 +1460,8 @@ static int __igt_mmap_access(struct drm_i915_private *i915, > if (err) > return err; > > - addr = igt_mmap_offset(i915, offset, obj->base.size, PROT_WRITE, MAP_SHARED); > + addr = igt_mmap_offset(i915, offset, obj->base.size, > + PROT_READ | PROT_WRITE, MAP_SHARED); > if (IS_ERR_VALUE(addr)) > return addr; > ptr = (unsigned long __user *)addr; > > -- > 2.43.0 > -- Cheers, Lorenzo