From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/boot: remove unused min_t/max_t macros
Date: Fri, 29 May 2026 11:52:08 +0200 [thread overview]
Message-ID: <b00339e7-ff69-4679-9d7c-56768b784db2@kernel.org> (raw)
In-Reply-To: <ahlgQZW7z7Ht4qpS@linux.dev>
Le 29/05/2026 à 11:45, Thorsten Blum a écrit :
> Hi Christophe,
>
> On Fri, May 29, 2026 at 11:10:20AM +0200, Christophe Leroy (CS GROUP) wrote:
>>
>>
>> Le 25/05/2026 à 11:18, Thorsten Blum a écrit :
>>> The min_t() and max_t() macros are no longer used by the boot wrapper,
>>> remove them.
>>
>> Did you test your change ?
>
> Yes, but with Gzip and not with XZ, and by grepping for min_t/max_t in
> arch/powerpc/boot/. I (wrongly) assumed that arch/powerpc/boot/ is
> self-contained.
You could have figured out with 'git blame arch/powerpc/boot/types.h'
that those lines were added by commit c762c69e106f ("powerpc/boot: Add
support for XZ compression")
>
> Thanks for catching this, and please drop this patch for now as I wasn't
> aware of the dependency to lib/xz/.
next prev parent reply other threads:[~2026-05-29 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 9:18 [PATCH] powerpc/boot: remove unused min_t/max_t macros Thorsten Blum
2026-05-29 9:10 ` Christophe Leroy (CS GROUP)
2026-05-29 9:45 ` Thorsten Blum
2026-05-29 9:52 ` Christophe Leroy (CS GROUP) [this message]
2026-05-29 19:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b00339e7-ff69-4679-9d7c-56768b784db2@kernel.org \
--to=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox