From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFE5BCCF9E3 for ; Thu, 23 Oct 2025 19:37:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4csxC52G3lz3bf8; Fri, 24 Oct 2025 06:37:53 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1761248273; cv=none; b=iNqa0EOnJM8i7UqaPkKSurQRLKyGyfDqSnZ0VfYRtezunHFKP004zxUkve+Dkq+sd1zpwHQNwOAmk47+w4hAHRgXMWJLPjdliRgE4bcKTcr8dl6AOHdedCekyRsxko9gmbAVtGH5rcYgEHFK3ceCMWmLOzeNTvThTZgSyEhKpWKdBonlifZu8YayX1OE70naFAiVsCVeCgWMNcm8mCwaMBxtPbpu+rb0oQ1JRP5x66M0AnKy3/+6UO9KAhXYOVk6hOf189y04NzPz73vr+HSyQhUmIFQ2EGPYlMdw/ddoa4EAiQTpyEy3M62tBytjvlupz8Dy0fhvAshFdH7Y7kx8g== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1761248273; c=relaxed/relaxed; bh=mPouUhrqRxgjcMBstonzlhFIxQsnreNI+UXdXwtR76k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h9hNzYeSgxK8m7MHua8zsguPafp31sUZDnhCnJUn8pERho+KlHCcvSFdD71LZVeJuLeql4Er7+nkZ7w4pZ3BXDoHehqo7ubVWXdM9FZLvT9dDpzTl564Ov2shKin9Nrub+9zK60bgThTtYfR92i4BYClmDavs3H5w3A4tEXvTFn9lB3/1QIfdWP2nomC4Md4XArHR7P4fhCvzm16rbp69DWvaMRDfsmxhYWUnJka+rd+fiySalEo6K02SOWn+vRlcVYP79kjYD/vIaDG1nozJuHIDl1cppVSmNqbQ0rCPvR8Ohd8b9XJN/xJcnyonzOa9FpsbX50wE1ZTrwbgGiwoA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hgPwBE+z; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hgPwBE+z; dkim-atps=neutral; spf=pass (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hgPwBE+z; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hgPwBE+z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4csxC43bCzz3bf4 for ; Fri, 24 Oct 2025 06:37:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761248270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mPouUhrqRxgjcMBstonzlhFIxQsnreNI+UXdXwtR76k=; b=hgPwBE+zSgNpt4kVXGHGa/kYW/dBIiWcCY6Pi5u8XG1TlbYY4kNIX/YcsC+wEwZ/M32S3z xDd39QO1K8NZvjYbXPewiMagmi44GQwYBAi1NI16l0Bbo/q9NPEqkQ0wRJsUuQe3LKus6E IVV/iyVSx6f2NQ4JpS2pyketTlLNcFw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761248270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mPouUhrqRxgjcMBstonzlhFIxQsnreNI+UXdXwtR76k=; b=hgPwBE+zSgNpt4kVXGHGa/kYW/dBIiWcCY6Pi5u8XG1TlbYY4kNIX/YcsC+wEwZ/M32S3z xDd39QO1K8NZvjYbXPewiMagmi44GQwYBAi1NI16l0Bbo/q9NPEqkQ0wRJsUuQe3LKus6E IVV/iyVSx6f2NQ4JpS2pyketTlLNcFw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-KN2bZW_RO0WNvHaPi_OCiA-1; Thu, 23 Oct 2025 15:37:46 -0400 X-MC-Unique: KN2bZW_RO0WNvHaPi_OCiA-1 X-Mimecast-MFC-AGG-ID: KN2bZW_RO0WNvHaPi_OCiA_1761248265 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-471125c8bc1so16183725e9.3 for ; Thu, 23 Oct 2025 12:37:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761248265; x=1761853065; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mPouUhrqRxgjcMBstonzlhFIxQsnreNI+UXdXwtR76k=; b=EejOl0QFYEuRhqENBjecfnMs1bmsN264/JyJusARclKZcJzGR1KrKVIiAqzzeVbTcE +OF7RwI+1HyBKGpGbeBElQbMji1n8+TrFAqI6bk30DRZnwMNTmFTD5wTciu4yX36LoeY yi2qHM48iyLG1B+HwT0oVwTgfTPc05KiwbkKlit3j0owMuehHVHKhlBHK5Ew+Ge/8Hl+ iZsA+wDkrkIgSESdMJL4aFeXTkemhNEfpR7Isa0FNz/Pv5Q1eA6KEiZ7/O5KvnrGZDop NNa8inohi3rKqL39M8kHcDwHKCGh063iXVIa9Ml8zVMqZUj74EkTGkdJWmuS509Wvg9O GK/Q== X-Forwarded-Encrypted: i=1; AJvYcCU+63tjd6POAah4cqKcIAY1GwG7wTwjQC4Ur8cJINoZ1fAl0T5cPmuA2WsghJe++KSuqG7Fcm1x50+K9NQ=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yz8CZC6Eb3EY8cQsjDtc0PFnm67fSPIb//Kaxau55Jk910NV25L bc7h4PBHoMetURFQU2dp2bgXsiYQmRBloMJWcLWhoI9wyEx6p5FO9l5xPYaoksICZZm4dN7qNjN jevBRRqqx535Fnl2FlwIcZAZF3xvPWctuKx60VT+3C5Vg5PZwvTPd1N53MWpl1QlTCo0= X-Gm-Gg: ASbGnctXDAJJo3MIjgkx5RCQsqzvrOZSd0nmWLYQFD+juAln5cxbXnI5B5Et4uPprkW R5DANJLAN4oSsgjt5j7fRM29ewln5xng8OcfzNpt34jxZSq4VwM3B43z4OGaEgPsfdwQVDbu16D hcFegAvYuS9FVipnje0FL3iQ3YZrSVQapd/rOjxGD9zDiyfFJrXyGCeJzu0gGQ6nb5cVSKskh1y ql/NZz3Jh03twpBqOT6ag7PwcXUrdegvhz+Om9Vov74vdbldbGTXAtK63q+MdN1x2LpUywhXTJX FqF8M9xd+ZyF9+FvNMxYPHbSube+QNShvIqEz4JPROmk3Mqk5fp3nvAgz1wRFG94VNHqG9zeBg2 gMorvVh+RgH1LA/DjPUr0wIXHevgf0uNqF+OfDLeDMPxclVaGEc1lTZhZIaxh08zTLftz4En3jN nLHyApTYmp6RzRsyn9WiJqNBAlyaY= X-Received: by 2002:a05:600c:3149:b0:46e:4b8b:75f2 with SMTP id 5b1f17b1804b1-471178a7ea5mr175792225e9.16.1761248265270; Thu, 23 Oct 2025 12:37:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZq8ETk/dxv6lw5okKbvprrCeAKa5W7ysoK9CYeQHAr2H0Pl+EqcgQ1cUF8EEIwcu7bpKOCw== X-Received: by 2002:a05:600c:3149:b0:46e:4b8b:75f2 with SMTP id 5b1f17b1804b1-471178a7ea5mr175791855e9.16.1761248264842; Thu, 23 Oct 2025 12:37:44 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c4369b5esm130845595e9.15.2025.10.23.12.37.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 12:37:44 -0700 (PDT) Message-ID: Date: Thu, 23 Oct 2025 21:37:42 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/13] sparc/mm: implement arch_flush_lazy_mmu_mode() To: Kevin Brodsky , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20251015082727.2395128-1-kevin.brodsky@arm.com> <20251015082727.2395128-5-kevin.brodsky@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251015082727.2395128-5-kevin.brodsky@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ur8QjPa3tg5X5fpulmxVFE30Gpi6eFPNmsgH_FRiqWE_1761248265 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.10.25 10:27, Kevin Brodsky wrote: > Upcoming changes to the lazy_mmu API will cause > arch_flush_lazy_mmu_mode() to be called when leaving a nested > lazy_mmu section. > > Move the relevant logic from arch_leave_lazy_mmu_mode() to > arch_flush_lazy_mmu_mode() and have the former call the latter. > > Signed-off-by: Kevin Brodsky > --- > arch/sparc/include/asm/tlbflush_64.h | 2 +- > arch/sparc/mm/tlb.c | 9 ++++++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/sparc/include/asm/tlbflush_64.h b/arch/sparc/include/asm/tlbflush_64.h > index 8b8cdaa69272..925bb5d7a4e1 100644 > --- a/arch/sparc/include/asm/tlbflush_64.h > +++ b/arch/sparc/include/asm/tlbflush_64.h > @@ -43,8 +43,8 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end); > > void flush_tlb_pending(void); > void arch_enter_lazy_mmu_mode(void); > +void arch_flush_lazy_mmu_mode(void); > void arch_leave_lazy_mmu_mode(void); > -#define arch_flush_lazy_mmu_mode() do {} while (0) > > /* Local cpu only. */ > void __flush_tlb_all(void); > diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c > index a35ddcca5e76..7b5dfcdb1243 100644 > --- a/arch/sparc/mm/tlb.c > +++ b/arch/sparc/mm/tlb.c > @@ -59,12 +59,19 @@ void arch_enter_lazy_mmu_mode(void) > tb->active = 1; > } > > -void arch_leave_lazy_mmu_mode(void) > +void arch_flush_lazy_mmu_mode(void) > { > struct tlb_batch *tb = this_cpu_ptr(&tlb_batch); > > if (tb->tlb_nr) > flush_tlb_pending(); > +} > + > +void arch_leave_lazy_mmu_mode(void) > +{ > + struct tlb_batch *tb = this_cpu_ptr(&tlb_batch); > + Just like for ppc now a double this_cpu_ptr(). I'd similarly just replicate the two statements. > + arch_flush_lazy_mmu_mode(); > tb->active = 0; > preempt_enable(); > } -- Cheers David / dhildenb