From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Pali Rohár" <pali@kernel.org>
Cc: Sinan Akman <sinan@writeme.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Scott Wood <oss@buserror.net>,
Martin Kennedy <hurricos@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c
Date: Tue, 14 Feb 2023 05:49:24 +0000 [thread overview]
Message-ID: <b0763d5d-20a1-1ece-f9c1-2ef91c196629@csgroup.eu> (raw)
In-Reply-To: <20230213201504.ovc6jf5iyo4s47pf@pali>
Le 13/02/2023 à 21:15, Pali Rohár a écrit :
> On Monday 13 February 2023 20:05:09 Christophe Leroy wrote:
>> Le 24/12/2022 à 22:14, Pali Rohár a écrit :
>>> +#ifdef CONFIG_MPC85xx_RDB
>>> +static void __init mpc85xx_rdb_pic_init(void)
>>> +{
>>> + struct mpic *mpic;
>>> +
>>> + mpic = mpic_alloc(NULL, 0,
>>> + MPIC_BIG_ENDIAN |
>>> + MPIC_SINGLE_DEST_CPU,
>>> + 0, 256, " OpenPIC ");
>>
>> Can you make it a single line ? At least no more than two lines ?
>
> All these lines are already present in kernel tree.
> So it could be fixed in separate patch.
>
> If needed I can do it as part of this series in new patch.
>
Well, that goes away in patch 5. So it is not really worth it.
next prev parent reply other threads:[~2023-02-14 5:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 21:14 [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2022-12-24 21:14 ` [PATCH v2 1/8] powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static Pali Rohár
2022-12-24 21:14 ` [PATCH v2 2/8] powerpc/85xx: Mark mpc85xx_ds_pic_init() " Pali Rohár
2022-12-24 21:14 ` [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c Pali Rohár
2023-02-03 19:08 ` Pali Rohár
2023-02-13 20:05 ` Christophe Leroy
2023-02-13 20:15 ` Pali Rohár
2023-02-14 5:49 ` Christophe Leroy [this message]
2022-12-24 21:14 ` [PATCH v2 4/8] powerpc/85xx: p2020: Move i8259 code into own function Pali Rohár
2023-02-13 20:06 ` Christophe Leroy
2023-02-13 20:17 ` Pali Rohár
2022-12-24 21:14 ` [PATCH v2 5/8] powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks Pali Rohár
2022-12-24 21:14 ` [PATCH v2 6/8] powerpc/85xx: p2020: Define just one machine description Pali Rohár
2023-02-13 20:08 ` Christophe Leroy
2023-02-13 20:18 ` Pali Rohár
2022-12-24 21:14 ` [PATCH v2 7/8] powerpc/85xx: p2020: Enable boards by new config option CONFIG_PPC_P2020 Pali Rohár
2022-12-24 21:14 ` [PATCH v2 8/8] powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string Pali Rohár
2023-01-22 11:16 ` [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2023-01-23 14:32 ` Christophe Leroy
2023-01-23 20:09 ` Pali Rohár
2023-02-09 0:15 ` Pali Rohár
2023-02-13 19:58 ` Christophe Leroy
2023-02-13 20:11 ` Pali Rohár
2023-02-14 5:47 ` Christophe Leroy
2023-02-15 18:57 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0763d5d-20a1-1ece-f9c1-2ef91c196629@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=hurricos@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=oss@buserror.net \
--cc=pali@kernel.org \
--cc=sinan@writeme.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).