From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Daniel Axtens <dja@axtens.net>,
Geliang Tang <geliangtang@163.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Paul Mackerras <paulus@samba.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: powerpc/nvram: Move an assignment for the variable "ret" in dev_nvram_write()
Date: Fri, 20 Jan 2017 08:08:55 +0100 [thread overview]
Message-ID: <b0958392-8325-4f56-cded-0ff6691893cf@users.sourceforge.net> (raw)
In-Reply-To: <52f46c9b-e049-7288-2c53-9c2525cd84c6@linux.vnet.ibm.com>
> I think you really could have squashed patches 1-3 into a single patch
> that returns directly after any failure.
Thanks for your constructive feedback.
I have got software development concerns around such patch squashing.
> At this point you might as well remove that label and move the kfree(tmp) call up
> and return directly after the failure and at the nvram_write() call site
> doing away completely with the "ret" variable.
Your idea might look nice at first glance. But I would interpret the previous
implementation of the discussed function in the way that the memory which was
dynamically allocated here should always (not only in the failure case) be released
before returning here.
Would you really like to change the life time for this “temporary” data item?
Regards,
Markus
next prev parent reply other threads:[~2017-01-20 7:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 16:52 [PATCH 0/8] PowerPC-NVRAM: Fine-tuning for some function implementations SF Markus Elfring
2017-01-19 16:53 ` [PATCH 1/8] powerpc/nvram: Return directly after a failed parameter validation in dev_nvram_write() SF Markus Elfring
2017-01-19 16:55 ` [PATCH 2/8] powerpc/nvram: Return directly after a failed kmalloc() " SF Markus Elfring
2017-01-19 16:56 ` [PATCH 3/8] powerpc/nvram: Move an assignment for the variable "ret" " SF Markus Elfring
2017-01-20 0:24 ` Tyrel Datwyler
2017-01-20 7:08 ` SF Markus Elfring [this message]
2017-01-20 20:52 ` Tyrel Datwyler
2017-01-19 16:57 ` [PATCH 4/8] powerpc/nvram: Return directly after a failed parameter validation in dev_nvram_read() SF Markus Elfring
2017-01-19 16:59 ` [PATCH 5/8] powerpc/nvram: Return directly after a failed kmalloc() " SF Markus Elfring
2017-01-19 17:00 ` [PATCH 6/8] powerpc/nvram: Delete three error messages for a failed memory allocation SF Markus Elfring
2017-01-19 17:03 ` [PATCH 7/8] powerpc/nvram: Improve size determinations in three functions SF Markus Elfring
2017-01-19 17:05 ` [PATCH 8/8] powerpc/nvram: Move an assignment for the variable "err" in nvram_scan_partitions() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0958392-8325-4f56-cded-0ff6691893cf@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=benh@kernel.crashing.org \
--cc=dja@axtens.net \
--cc=geliangtang@163.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
--cc=tyreld@linux.vnet.ibm.com \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).