From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F05D8C54EE9 for ; Tue, 27 Sep 2022 03:32:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Mc4vY4MDnz3c46 for ; Tue, 27 Sep 2022 13:32:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dn7S0QDZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=bgray@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dn7S0QDZ; dkim-atps=neutral Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Mc4tp1dCMz3088 for ; Tue, 27 Sep 2022 13:32:17 +1000 (AEST) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28R3EHfq019875; Tue, 27 Sep 2022 03:32:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=yEkAYJz/F/W8eCwSGH/Le6n4i+Mf8ZkNw31EyxMuo4Y=; b=dn7S0QDZIOhIDD7cxls585t2xu7vIQ9nxJtqg7YXUkyBOK70p496D5cJvNW3w32mc9pc kdfQAqvXM8DD1kMzYXOOnJyhdJFH+L0NvJHha9z+ehec3msao6pRPCn2tPHFAEYxUdC4 ObTwpQuhnVino6dhxP4HY2qhufAJ2FdnQE+bgrbookQ4hVXP7B9GhHBizGF/87thQRge U51aJ2G0pdfKlQKtLKnj0qmpnlcuaJausQU4NRPyI67Dvgg7p83LLlzT4zEKat2FTpkK PDWwskrlgRFhkIzt0hodL1j0gHk3DjuIpH6d0l8+5fK7GBtsRj1SNXaQabWAJ6xhEVA1 sw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jus3hga3w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 03:32:03 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 28R3U8OF009944; Tue, 27 Sep 2022 03:32:02 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jus3hga3e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 03:32:02 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 28R3KNSV003976; Tue, 27 Sep 2022 03:32:01 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma05fra.de.ibm.com with ESMTP id 3jssh8td6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 03:32:00 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 28R3VwOR4850224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Sep 2022 03:31:58 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 679DEA404D; Tue, 27 Sep 2022 03:31:58 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10CE0A4040; Tue, 27 Sep 2022 03:31:58 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 27 Sep 2022 03:31:58 +0000 (GMT) Received: from [10.61.2.107] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 5B7DF6016C; Tue, 27 Sep 2022 13:31:55 +1000 (AEST) Message-ID: Subject: Re: [PATCH v2 6/6] powerpc/64: Add tests for out-of-line static calls From: Benjamin Gray To: Christophe Leroy , "linuxppc-dev@lists.ozlabs.org" Date: Tue, 27 Sep 2022 13:31:55 +1000 In-Reply-To: <50424b8b-a855-c8b1-bc86-685614f653a6@csgroup.eu> References: <20220926064316.765967-1-bgray@linux.ibm.com> <20220926064316.765967-7-bgray@linux.ibm.com> <50424b8b-a855-c8b1-bc86-685614f653a6@csgroup.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ypqwIMLTVgeOIsLurZdhi53vrsy1YuUa X-Proofpoint-ORIG-GUID: I5jo9DGPoJ6tT8VDuwaKEZETI4jMEt_k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-26_11,2022-09-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209270016 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ajd@linux.ibm.com" , "peterz@infradead.org" , "npiggin@gmail.com" , "ardb@kernel.org" , "jbaron@akamai.com" , "rostedt@goodmis.org" , "jpoimboe@kernel.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 2022-09-26 at 14:55 +0000, Christophe Leroy wrote: > > +config PPC_STATIC_CALL_KUNIT_TEST > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0tristate "KUnit tests for PP= C64 ELF ABI V2 static calls" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0default KUNIT_ALL_TESTS > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends on HAVE_STATIC_CALL = && PPC64_ELF_ABI_V2 && KUNIT && > > m >=20 > Is there a reason why it is dedicated to PPC64 ? In that case, can > you=20 > make it explicit with the name of the config option, and with the > name=20 > of the file below ? The tests were written to make sure the TOC stays correct, so in theory PPC64_ELF_ABI_V2 (and potentially PPC64_ELF_ABI_V1) is the only ABI that should need them. I was thinking other tests should probably go in static_call_selftest.c Thinking now though, I suppose runtime modules are out-of-range for branches on 32-bit as well? I can see it being useful for just testing the indirect branch fallback in that case, without trying to make some generic test suite that needs to work on other arches. The TOC specific checks can be conditionally enabled per ABI.