From: Michael Bringmann <mwb@linux.vnet.ibm.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Rob Herring <robh@kernel.org>, Kees Cook <keescook@chromium.org>,
Nicholas Piggin <npiggin@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>, Juliet Kim <minkim@us.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
"open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)"
<linuxppc-dev@lists.ozlabs.org>,
Guenter Roeck <linux@roeck-us.net>,
Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update
Date: Wed, 14 Nov 2018 08:13:39 -0600 [thread overview]
Message-ID: <b21e9681-74a8-bc67-8342-634198b69491@linux.vnet.ibm.com> (raw)
In-Reply-To: <20181113083902.GA24474@linux.vnet.ibm.com>
On 11/13/2018 02:39 AM, Srikar Dronamraju wrote:
>> -static void topology_work_fn(struct work_struct *work)
>> -{
>> - rebuild_sched_domains();
>> + if (changed)
>> + rebuild_sched_domains();
>> }
>> static DECLARE_WORK(topology_work, topology_work_fn);
>>
>> @@ -1553,7 +1424,6 @@ void __init shared_proc_topology_init(void)
>> if (lppaca_shared_proc(get_lppaca())) {
>> bitmap_fill(cpumask_bits(&cpu_associativity_changes_mask),
>> nr_cpumask_bits);
>> - numa_update_cpu_topology(false);
>
> Shouldn't we be calling topology_schedule_update() here?
Agreed.
>
>> }
>> }
>>
>
>
--
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line 363-5196
External: (512) 286-5196
Cell: (512) 466-0650
mwb@linux.vnet.ibm.com
prev parent reply other threads:[~2018-11-14 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 18:53 [PATCH] powerpc/numa: Perform full re-add of CPU for PRRN/VPHN topology update Michael Bringmann
2018-11-13 8:39 ` Srikar Dronamraju
2018-11-14 14:13 ` Michael Bringmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21e9681-74a8-bc67-8342-634198b69491@linux.vnet.ibm.com \
--to=mwb@linux.vnet.ibm.com \
--cc=clabbe@baylibre.com \
--cc=keescook@chromium.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minkim@us.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=robh@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).