From: Keshava Munegowda <keshava_mgowda@ti.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>, Tirumala Marri <tmarri@apm.com>
Cc: Mark Miesfeld <mmiesfeld@apm.com>,
greg@kroah.com, linux-usb@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Fushen Chen <fchen@apm.com>
Subject: RE: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)
Date: Tue, 5 Apr 2011 12:38:03 +0530 [thread overview]
Message-ID: <b284084fc5fc0d15e13cbfaf926ee1ce@mail.gmail.com> (raw)
In-Reply-To: <4D961FBA.8090107@ru.mvista.com>
> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov@mvista.com]
> Sent: Saturday, April 02, 2011 12:26 AM
> To: Tirumala Marri
> Cc: Keshava Munegowda; linux-usb@vger.kernel.org;
linuxppc-dev@lists.ozlabs.org; greg@kroah.com;
> Fushen Chen; Mark Miesfeld
> Subject: Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core
Interface Layer (CIL)
>
> Hello.
>
> Tirumala Marri wrote:
>
> >>> +void dwc_otg_core_init(struct core_if *core_if)
> >>> +{
> >>> + u32 i;
> >>> + ulong global_reg = core_if->core_global_regs;
> >>> + struct device_if *dev_if = core_if->dev_if;
> >>> + u32 ahbcfg = 0;
> >>> + u32 i2cctl = 0;
> >>> + u32 gusbcfg;
>
> >> Tabify the declarations ;
>
> > [Marri] When I checked again in my source, I do see the tabs added
before
> > declarations.
>
> He means that tabs should be between the variable's type and name,
but
> there's no such requirement actually.
I am sorry if there is no such requirement, since I had such comments and
I fixed it and
Now I have commented.
Keshava Munegowda
next prev parent reply other threads:[~2011-04-05 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 18:27 [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL) tmarri
2011-03-29 10:51 ` Keshava Munegowda
2011-04-01 17:35 ` Tirumala Marri
2011-04-01 18:55 ` Sergei Shtylyov
2011-04-05 7:08 ` Keshava Munegowda [this message]
2011-04-05 8:12 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b284084fc5fc0d15e13cbfaf926ee1ce@mail.gmail.com \
--to=keshava_mgowda@ti.com \
--cc=fchen@apm.com \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmiesfeld@apm.com \
--cc=sshtylyov@mvista.com \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).