From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0083.outbound.protection.outlook.com [104.47.37.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xSKJX49GHzDqjk for ; Thu, 10 Aug 2017 04:18:20 +1000 (AEST) Subject: Re: [RFC Part1 PATCH v3 02/17] x86/CPU/AMD: Add the Secure Encrypted Virtualization CPU feature To: Borislav Petkov Cc: Brijesh Singh , linux-kernel@vger.kernel.org, x86@kernel.org, linux-efi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Tony Luck , Piotr Luc , Fenghua Yu , Lu Baolu , Reza Arbab , David Howells , Matt Fleming , "Kirill A . Shutemov" , Laura Abbott , Ard Biesheuvel , Andrew Morton , Eric Biederman , Benjamin Herrenschmidt , Paul Mackerras , Konrad Rzeszutek Wilk , Jonathan Corbet , Dave Airlie , Kees Cook , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Arnd Bergmann , Tejun Heo , Christoph Lameter References: <20170724190757.11278-1-brijesh.singh@amd.com> <20170724190757.11278-3-brijesh.singh@amd.com> <20170725102657.GD21822@nazgul.tnic> <7236d267-ebcb-8b45-b8d3-5955903e395f@amd.com> <20170725143615.GA26029@nazgul.tnic> <47ccc32e-e113-48e0-d2e0-2f23b37cc452@amd.com> <20170725151301.GC26029@nazgul.tnic> <20170725153329.GE26029@nazgul.tnic> From: Tom Lendacky Message-ID: Date: Wed, 9 Aug 2017 13:17:54 -0500 MIME-Version: 1.0 In-Reply-To: <20170725153329.GE26029@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 7/25/2017 10:33 AM, Borislav Petkov wrote: > On Tue, Jul 25, 2017 at 10:29:40AM -0500, Tom Lendacky wrote: >> But early_identify_cpu() calls get_cpu_cap() which will check for cpuid >> leaf 0x80000008 support and set x86_phys_bits. > > Right, but it can't be less than 32, can it? And if it is more than 32 > bits, then it probably doesn't really matter on 32-bit. Unless it is > less than 36 bits and you do PAE... > >> I'll try to build and run a 32-bit kernel and see how this all flows. > > Yeah, that would be good. Ok, finally got around to running a 32-bit kernel and it reports x86_phys_bits as 48. Thanks, Tom > > Thanks. >