From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E43CFEB64DC for ; Thu, 29 Jun 2023 13:50:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=jYmdjI83; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=hdP5WXhT; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QsKbL1jk4z3bkM for ; Thu, 29 Jun 2023 23:50:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm1 header.b=jYmdjI83; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=hdP5WXhT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arndb.de (client-ip=64.147.123.17; helo=wnew3-smtp.messagingengine.com; envelope-from=arnd@arndb.de; receiver=lists.ozlabs.org) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QsJYM6khHz309q for ; Thu, 29 Jun 2023 23:03:51 +1000 (AEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 76C082B000EC; Thu, 29 Jun 2023 09:03:46 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 29 Jun 2023 09:03:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1688043826; x=1688051026; bh=UU HaYOR2mXOloOMHF3WLMCOR1A2U5vkl9suJPqtiWo0=; b=jYmdjI83UYYyF7IY+u 8g9McVnE3vPyh7glSNzH+p2DdU5ryP8UZ/cxpvpQF5S/pn4dHU1j+Mx0d5HMNkn0 Imm+u93oB5rHRaIXBems4pxGAHK7VFPs1bNA9+d8EbLLjt1VNLigUVjHvoO5eoXB lZyoP+XGxZQJ0trrINfRRc458VkK3D9Fs236LXlJaZwBV0f7KjN5QHbmhebF77A4 9PFaT1JB9FtKli3KJC1tUFARSnPTAY6jX4I8oRMpMjfwP7UWkxh57D4hi7lSCCBs dnF+fckq8Xxxq32v+RqKXtCYaJsFUSgmdURp16aFUAJPhosXmMvlfFNMdwyi/yFK kt6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688043826; x=1688051026; bh=UUHaYOR2mXOlo OMHF3WLMCOR1A2U5vkl9suJPqtiWo0=; b=hdP5WXhT7ekq4Hva1FpIeceGlZkjX PM41q+KTShehkEBcGvudvdIPePUv8Ic7Blw/ll4QeTRT7pV0R3bfB2XESZW/QMiK EdzLZilFODp/dnZvF9ehS6UPa5oI6e/qG3Cp9rBWySjwoX9uOe6Y6dLz4yTggGfH 1R0RHfJxaZNzPhyj1zvd/YVqF6hC4wqyXax2f8uUxqg7NK92S5j4d+Pcrg07JofZ 2U7YagxrLOV+A4i6wAVi6OtOrsKvUjjSmcqql82rqAup6A4/4JvLg4aixq1XeHJr X25DD68SpkISgTOGRrlgDcff8lBJNoYNXerguGZWUGBmEgrt1YSYc+dgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtdeggdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 688DEB60086; Thu, 29 Jun 2023 09:03:41 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230629121952.10559-7-tzimmermann@suse.de> References: <20230629121952.10559-1-tzimmermann@suse.de> <20230629121952.10559-7-tzimmermann@suse.de> Date: Thu, 29 Jun 2023 15:03:20 +0200 From: "Arnd Bergmann" To: "Thomas Zimmermann" , "Helge Deller" , "Daniel Vetter" , "Dave Airlie" Subject: Re: [PATCH 06/12] arch: Declare screen_info in Content-Type: text/plain X-Mailman-Approved-At: Thu, 29 Jun 2023 23:48:03 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, Anshuman Khandual , linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Linus Walleij , John Paul Adrian Glaubitz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Max Filippov , Rich Felker , guoren , "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , WANG Xuerui , Linux-Arch , "Kirill A. Shutemov" , Yoshinori Sato , linux-hexagon@vger.kernel.org, linux-staging@lists.linux.dev, Russell King , "linux-csky@vger.kernel.org" , Ard Bieshe uvel , Dave Hansen , Ingo Molnar , Geert Uytterhoeven , Sami Tolvanen , Juerg Haefliger , Matt Turner , Huacai Chen , Albert Ou , Kees Cook , "Paul E. McKenney" , Chris Zankel , Frederic Weisbecker , Richard Henderson , Nicholas Piggin , Russell King , Ivan Kokshaysky , loongarch@lists.linux.dev, Paul Walmsley , Thomas Gleixner , Zi Yan , linux-arm-kernel@lists.infradead.org, Brian Cain , Thomas Bogendoerfer , Sebastian Reichel , Niklas Schnelle , linux-kernel@vger.kernel.org, Dinh Nguyen , Palmer Dabbelt , Mike Rapoport , linux-alpha@vger.kernel.org, Borislav Petkov , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , x86@kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: > diff --git a/include/asm-generic/screen_info.h > b/include/asm-generic/screen_info.h > new file mode 100644 > index 0000000000000..6fd0e50fabfcd > --- /dev/null > +++ b/include/asm-generic/screen_info.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _ASM_GENERIC_SCREEN_INFO_H > +#define _ASM_GENERIC_SCREEN_INFO_H > + > +#include > + > +#if defined(CONFIG_ARCH_HAS_SCREEN_INFO) > +extern struct screen_info screen_info; > +#endif > + > +#endif /* _ASM_GENERIC_SCREEN_INFO_H */ > diff --git a/include/linux/screen_info.h b/include/linux/screen_info.h > index eab7081392d50..c764b9a51c24b 100644 > --- a/include/linux/screen_info.h > +++ b/include/linux/screen_info.h > @@ -4,6 +4,6 @@ > > #include > > -extern struct screen_info screen_info; > +#include > What is the purpose of adding a file in asm-generic? If all architectures use the same generic file, I'd just leave the declaration in include/linux/. I wouldn't bother adding the #ifdef either, but I can see how that helps turn a link error into an earlier compile error. Arnd