From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Joerg Roedel <jroedel@suse.de>,
kvm@vger.kernel.org, Fabiano Rosas <farosas@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
kvm-ppc@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Oliver O'Halloran <oohall@gmail.com>,
Joel Stanley <joel@jms.id.au>,
Robin Murphy <robin.murphy@arm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains
Date: Tue, 12 Jul 2022 12:27:17 +1000 [thread overview]
Message-ID: <b39583f2-e054-8fc7-430c-d52bf6ed5016@ozlabs.ru> (raw)
In-Reply-To: <YsxwDTBLxyo5W3uQ@nvidia.com>
On 7/12/22 04:46, Jason Gunthorpe wrote:
> On Mon, Jul 11, 2022 at 11:24:32PM +1000, Alexey Kardashevskiy wrote:
>
>> I really think that for 5.19 we should really move this blocked domain
>> business to Type1 like this:
>>
>> https://github.com/aik/linux/commit/96f80c8db03b181398ad355f6f90e574c3ada4bf
>
> This creates the same security bug for power we are discussing here. If you
How so? attach_dev() on power makes uninitalizes DMA setup for the group
on the hardware level, any other DMA user won't be able to initiate DMA.
> don't want to fix it then lets just merge this iommu_ops patch as is rather than
> mangle the core code.
The core code should not be assuming iommu_ops != NULL, Type1 should, I
thought it is the whole point of having Type1, why is not it the case
anymore?
--
Alexey
next prev parent reply other threads:[~2022-07-12 2:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 13:55 [PATCH kernel] powerpc/iommu: Add iommu_ops to report capabilities and allow blocking domains Alexey Kardashevskiy
2022-07-07 15:10 ` Jason Gunthorpe
2022-07-08 5:00 ` Alexey Kardashevskiy
2022-07-08 6:34 ` Alexey Kardashevskiy
2022-07-08 7:32 ` Tian, Kevin
2022-07-08 9:45 ` Alexey Kardashevskiy
2022-07-08 10:18 ` Tian, Kevin
2022-07-29 2:21 ` Alexey Kardashevskiy
2022-07-29 2:53 ` Oliver O'Halloran
2022-07-29 3:10 ` Tian, Kevin
2022-07-29 3:50 ` Alexey Kardashevskiy
2022-07-29 4:24 ` Tian, Kevin
2022-07-29 12:09 ` Jason Gunthorpe
2022-07-08 11:55 ` Jason Gunthorpe
2022-07-08 13:10 ` Alexey Kardashevskiy
2022-07-08 13:19 ` Jason Gunthorpe
2022-07-08 13:32 ` Alexey Kardashevskiy
2022-07-08 13:59 ` Jason Gunthorpe
2022-07-09 2:58 ` Alexey Kardashevskiy
2022-07-10 6:29 ` Jason Gunthorpe
2022-07-10 12:32 ` Alexey Kardashevskiy
2022-07-11 13:24 ` Alexey Kardashevskiy
2022-07-11 18:46 ` Jason Gunthorpe
2022-07-12 2:27 ` Alexey Kardashevskiy [this message]
2022-07-12 5:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b39583f2-e054-8fc7-430c-d52bf6ed5016@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=joel@jms.id.au \
--cc=jroedel@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=muriloo@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).